Re: [PATCH] iommu/arm-smmu: Demote error messages to debug in shutdown callback

Robin Murphy
2020-03-27T14:12:13Z

On 2020-03-27 1:28 pm, Sai Prakash Ranjan wrote:
> Currently on reboot/shutdown, the following messages are
> displayed on the console as error messages before the
> system reboots/shutdown.
>
> On SC7180:
>
> arm-smmu 15000000.iommu: removing device with active domains!
> arm-smmu 5040000.iommu: removing device with active domains!
>
> Demote the log level to debug since it does not offer much
> help in identifying/fixing any issue as the system is anyways
> going down and reduce spamming the kernel log.

I've gone back and forth on this pretty much ever since we added the
shutdown hook - on the other hand, if any devices *are* still running in
those domains at this point, then once we turn off the SMMU and let
those IOVAs go out on the bus as physical addresses, all manner of
weirdness may ensue. Thus there is an argument for *some* indication
that this may happen, although IMO it could be downgraded to at least
dev_warn().

Robin.

> Reported-by: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> ---
> drivers/iommu/arm-smmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index 16c4b87af42b..0a865e32054a 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -2250,7 +2250,7 @@ static int arm_smmu_device_remove(struct platform_device *pdev)
> return -ENODEV;
>
> if (!bitmap_empty(smmu->context_map, ARM_SMMU_MAX_CBS))
> - dev_err(&pdev->dev, "removing device with active domains!\n");
> + dev_dbg(&pdev->dev, "removing device with active domains!\n");
>
> arm_smmu_bus_init(NULL);
> iommu_device_unregister(&smmu->iommu);