Re: [PATCH v3 3/5] iommu/uapi: Use named union for user data

Jacob Pan
2020-06-24T15:41:36Z

On Wed, 24 Jun 2020 14:29:57 +0800
Lu Baolu <baolu.lu@linux.intel.com> wrote:

> > case IOMMU_CACHE_INV_TYPE_IOTLB:
> > /* HW will ignore LSB bits based on
> > address mask */ if (inv_info->granularity == IOMMU_INV_GRANU_ADDR &&
> > size &&
> > - (inv_info->addr_info.addr &
> > ((BIT(VTD_PAGE_SHIFT + size)) - 1))) {
> > + (inv_info->granu.addr_info.addr &
> > ((BIT(VTD_PAGE_SHIFT + size)) - 1))) {
>
> Nit: Keep it aligned. With this tweaked,
>
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
will do. Thanks.