From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute Date: Fri, 20 Jan 2012 17:03:44 +0100 Message-ID: <20120120160344.GG2205@amd.com> References: <1326983405-319-1-git-send-email-joerg.roedel@amd.com> <1326983405-319-3-git-send-email-joerg.roedel@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Sethi Varun-B16395 Cc: Ohad Ben-Cohen , Wood Scott-B07421 , Tony Lindgren , Hiroshi DOYU , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , Laurent Pinchart , David Brown , David Woodhouse List-Id: iommu@lists.linux-foundation.org On Thu, Jan 19, 2012 at 05:16:48PM +0000, Sethi Varun-B16395 wrote: > > struct iommu_domain { > > struct iommu_ops *ops; > > void *priv; > > iommu_fault_handler_t handler; > > + struct iommu_domain_geometry geometry; > > }; > In case of our iommu implementation the iommu_domain_geometry would > include additional attributes. Why can't we let the geometry be > Implementation dependent? Because the values in this generic geometry-struct make sense for more than one IOMMU (short-term for Tegra GART and Freescale PAMU). If you have additional vendor-specific ones you could add them via a vendor-specific attribute. Regards, Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632