* Re: [PATCH 8/8] ARM: dma-mapping: add support for IOMMU mapper [not found] ` <1323448798-18184-9-git-send-email-m.szyprowski@samsung.com> @ 2012-01-25 12:47 ` Hiroshi Doyu 2012-01-26 7:46 ` Marek Szyprowski [not found] ` <1326124161-2220-1-git-send-email-m.szyprowski@samsung.com> 1 sibling, 1 reply; 4+ messages in thread From: Hiroshi Doyu @ 2012-01-25 12:47 UTC (permalink / raw) To: Marek Szyprowski Cc: linux-arm-kernel@lists.infradead.org, linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-samsung-soc@vger.kernel.org, iommu@lists.linux-foundation.org, Shariq Hasnain, Arnd Bergmann, Benjamin Herrenschmidt, Krishna Reddy, Kyungmin Park, Andrzej Pietrasiewicz, Russell King - ARM Linux, KyongHo Cho, Chunsang Jeong Hi Marek, On Fri, 9 Dec 2011 17:39:58 +0100 Marek Szyprowski <m.szyprowski@samsung.com> wrote: > This patch add a complete implementation of DMA-mapping API for > devices that have IOMMU support. All DMA-mapping calls are supported. > > This patch contains some of the code kindly provided by Krishna Reddy > <vdumpa@nvidia.com> and Andrzej Pietrasiewicz <andrzej.p@samsung.com> > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > Add initial proof of concept implementation of DMA-mapping API for > devices that have IOMMU support. Right now only dma_alloc_coherent, > dma_free_coherent and dma_mmap_coherent functions are supported. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > arch/arm/Kconfig | 8 + > arch/arm/include/asm/device.h | 3 + > arch/arm/include/asm/dma-iommu.h | 36 +++ > arch/arm/mm/dma-mapping.c | 637 +++++++++++++++++++++++++++++++++++++- > arch/arm/mm/vmregion.h | 2 +- > 5 files changed, 671 insertions(+), 15 deletions(-) > create mode 100644 arch/arm/include/asm/dma-iommu.h > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 8827c9b..87416fc 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -42,6 +42,14 @@ config ARM > config ARM_HAS_SG_CHAIN > bool > > +config NEED_SG_DMA_LENGTH > + bool > + > +config ARM_DMA_USE_IOMMU > + select NEED_SG_DMA_LENGTH > + select ARM_HAS_SG_CHAIN > + bool > + > config HAVE_PWM > bool > > diff --git a/arch/arm/include/asm/device.h b/arch/arm/include/asm/device.h > index 6e2cb0e..b69c0d3 100644 > --- a/arch/arm/include/asm/device.h > +++ b/arch/arm/include/asm/device.h > @@ -14,6 +14,9 @@ struct dev_archdata { > #ifdef CONFIG_IOMMU_API > void *iommu; /* private IOMMU data */ > #endif > +#ifdef CONFIG_ARM_DMA_USE_IOMMU > + struct dma_iommu_mapping *mapping; > +#endif > }; > > struct omap_device; > diff --git a/arch/arm/include/asm/dma-iommu.h b/arch/arm/include/asm/dma-iommu.h > new file mode 100644 > index 0000000..6668b41 > --- /dev/null > +++ b/arch/arm/include/asm/dma-iommu.h > @@ -0,0 +1,36 @@ > +#ifndef ASMARM_DMA_IOMMU_H > +#define ASMARM_DMA_IOMMU_H > + > +#ifdef __KERNEL__ > + > +#include <linux/mm_types.h> > +#include <linux/scatterlist.h> > +#include <linux/dma-debug.h> > +#include <linux/kmemcheck.h> > + > +#include <asm/memory.h> > + > +struct dma_iommu_mapping { > + /* iommu specific data */ > + struct iommu_domain *domain; > + > + void *bitmap; > + size_t bits; > + unsigned int order; > + dma_addr_t base; > + > + spinlock_t lock; > + struct kref kref; > +}; > + > +struct dma_iommu_mapping * > +arm_iommu_create_mapping(struct bus_type *bus, dma_addr_t base, size_t size, > + int order); > + > +void arm_iommu_release_mapping(struct dma_iommu_mapping *mapping); > + > +int arm_iommu_attach_device(struct device *dev, > + struct dma_iommu_mapping *mapping); > + > +#endif /* __KERNEL__ */ > +#endif > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c > index 4845c09..7ac5a95 100644 > --- a/arch/arm/mm/dma-mapping.c > +++ b/arch/arm/mm/dma-mapping.c > @@ -27,6 +27,9 @@ > #include <asm/sizes.h> > #include <asm/mach/arch.h> > > +#include <linux/iommu.h> > +#include <asm/dma-iommu.h> > + > #include "mm.h" > > /* ..... > + > +static void arm_iommu_unmap_page(struct device *dev, dma_addr_t handle, > + size_t size, enum dma_data_direction dir, > + struct dma_attrs *attrs) > +{ > + struct dma_iommu_mapping *mapping = dev->archdata.mapping; > + dma_addr_t iova = handle & PAGE_MASK; > + struct page *page = phys_to_page(iommu_iova_to_phys(mapping->domain, iova)); > + int offset = handle & ~PAGE_MASK; > + > + if (!iova) > + return; > + > + if (!arch_is_coherent()) > + __dma_page_dev_to_cpu(page, offset, size, dir); > + > + iommu_unmap(mapping->domain, iova, size); Is __free_iova() needed here as below? Modified arch/arm/mm/dma-mapping.c diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index 9aa1675..66830b2 100644 --- a/arch/arm/mm/dma-mapping.c +++ b/arch/arm/mm/dma-mapping.c @@ -1212,6 +1212,7 @@ static void arm_iommu_unmap_page(struct device *dev, dma_addr_t handle, __dma_page_dev_to_cpu(page, offset, size, dir); iommu_unmap(mapping->domain, iova, size); + __free_iova(mapping, iova, size); } ^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH 8/8] ARM: dma-mapping: add support for IOMMU mapper 2012-01-25 12:47 ` [PATCH 8/8] ARM: dma-mapping: add support for IOMMU mapper Hiroshi Doyu @ 2012-01-26 7:46 ` Marek Szyprowski 0 siblings, 0 replies; 4+ messages in thread From: Marek Szyprowski @ 2012-01-26 7:46 UTC (permalink / raw) To: 'Hiroshi Doyu' Cc: linux-arm-kernel, linaro-mm-sig, linux-mm, linux-arch, linux-samsung-soc, iommu, 'Shariq Hasnain', 'Arnd Bergmann', 'Benjamin Herrenschmidt', 'Krishna Reddy', 'Kyungmin Park', Andrzej Pietrasiewicz, 'Russell King - ARM Linux', 'KyongHo Cho', 'Chunsang Jeong' Hello, On Wednesday, January 25, 2012 1:47 PM Hiroshi Doyu wrote: > Hi Marek, > > On Fri, 9 Dec 2011 17:39:58 +0100 > Marek Szyprowski <m.szyprowski@samsung.com> wrote: > > > This patch add a complete implementation of DMA-mapping API for > > devices that have IOMMU support. All DMA-mapping calls are supported. > > > > This patch contains some of the code kindly provided by Krishna Reddy > > <vdumpa@nvidia.com> and Andrzej Pietrasiewicz <andrzej.p@samsung.com> > > > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > > > Add initial proof of concept implementation of DMA-mapping API for > > devices that have IOMMU support. Right now only dma_alloc_coherent, > > dma_free_coherent and dma_mmap_coherent functions are supported. > > > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > --- > > arch/arm/Kconfig | 8 + > > arch/arm/include/asm/device.h | 3 + > > arch/arm/include/asm/dma-iommu.h | 36 +++ > > arch/arm/mm/dma-mapping.c | 637 +++++++++++++++++++++++++++++++++++++- > > arch/arm/mm/vmregion.h | 2 +- > > 5 files changed, 671 insertions(+), 15 deletions(-) > > create mode 100644 arch/arm/include/asm/dma-iommu.h > > > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > > index 8827c9b..87416fc 100644 > > --- a/arch/arm/Kconfig > > +++ b/arch/arm/Kconfig > > @@ -42,6 +42,14 @@ config ARM > > config ARM_HAS_SG_CHAIN > > bool > > > > +config NEED_SG_DMA_LENGTH > > + bool > > + > > +config ARM_DMA_USE_IOMMU > > + select NEED_SG_DMA_LENGTH > > + select ARM_HAS_SG_CHAIN > > + bool > > + > > config HAVE_PWM > > bool > > > > diff --git a/arch/arm/include/asm/device.h b/arch/arm/include/asm/device.h > > index 6e2cb0e..b69c0d3 100644 > > --- a/arch/arm/include/asm/device.h > > +++ b/arch/arm/include/asm/device.h > > @@ -14,6 +14,9 @@ struct dev_archdata { > > #ifdef CONFIG_IOMMU_API > > void *iommu; /* private IOMMU data */ > > #endif > > +#ifdef CONFIG_ARM_DMA_USE_IOMMU > > + struct dma_iommu_mapping *mapping; > > +#endif > > }; > > > > struct omap_device; > > diff --git a/arch/arm/include/asm/dma-iommu.h b/arch/arm/include/asm/dma-iommu.h > > new file mode 100644 > > index 0000000..6668b41 > > --- /dev/null > > +++ b/arch/arm/include/asm/dma-iommu.h > > @@ -0,0 +1,36 @@ > > +#ifndef ASMARM_DMA_IOMMU_H > > +#define ASMARM_DMA_IOMMU_H > > + > > +#ifdef __KERNEL__ > > + > > +#include <linux/mm_types.h> > > +#include <linux/scatterlist.h> > > +#include <linux/dma-debug.h> > > +#include <linux/kmemcheck.h> > > + > > +#include <asm/memory.h> > > + > > +struct dma_iommu_mapping { > > + /* iommu specific data */ > > + struct iommu_domain *domain; > > + > > + void *bitmap; > > + size_t bits; > > + unsigned int order; > > + dma_addr_t base; > > + > > + spinlock_t lock; > > + struct kref kref; > > +}; > > + > > +struct dma_iommu_mapping * > > +arm_iommu_create_mapping(struct bus_type *bus, dma_addr_t base, size_t size, > > + int order); > > + > > +void arm_iommu_release_mapping(struct dma_iommu_mapping *mapping); > > + > > +int arm_iommu_attach_device(struct device *dev, > > + struct dma_iommu_mapping *mapping); > > + > > +#endif /* __KERNEL__ */ > > +#endif > > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c > > index 4845c09..7ac5a95 100644 > > --- a/arch/arm/mm/dma-mapping.c > > +++ b/arch/arm/mm/dma-mapping.c > > @@ -27,6 +27,9 @@ > > #include <asm/sizes.h> > > #include <asm/mach/arch.h> > > > > +#include <linux/iommu.h> > > +#include <asm/dma-iommu.h> > > + > > #include "mm.h" > > > > /* > ..... > > + > > +static void arm_iommu_unmap_page(struct device *dev, dma_addr_t handle, > > + size_t size, enum dma_data_direction dir, > > + struct dma_attrs *attrs) > > +{ > > + struct dma_iommu_mapping *mapping = dev->archdata.mapping; > > + dma_addr_t iova = handle & PAGE_MASK; > > + struct page *page = phys_to_page(iommu_iova_to_phys(mapping->domain, iova)); > > + int offset = handle & ~PAGE_MASK; > > + > > + if (!iova) > > + return; > > + > > + if (!arch_is_coherent()) > > + __dma_page_dev_to_cpu(page, offset, size, dir); > > + > > + iommu_unmap(mapping->domain, iova, size); > > Is __free_iova() needed here as below? > > Modified arch/arm/mm/dma-mapping.c > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c > index 9aa1675..66830b2 100644 > --- a/arch/arm/mm/dma-mapping.c > +++ b/arch/arm/mm/dma-mapping.c > @@ -1212,6 +1212,7 @@ static void arm_iommu_unmap_page(struct device *dev, dma_addr_t handle, > __dma_page_dev_to_cpu(page, offset, size, dir); > > iommu_unmap(mapping->domain, iova, size); > + __free_iova(mapping, iova, size); > } Right, thanks for finding this bug! Best regards -- Marek Szyprowski Samsung Poland R&D Center ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <1326124161-2220-1-git-send-email-m.szyprowski@samsung.com>]
* Re: [PATCH 8/8 RESEND] ARM: dma-mapping: add support for IOMMU mapper [not found] ` <1326124161-2220-1-git-send-email-m.szyprowski@samsung.com> @ 2012-01-25 12:59 ` Russell King - ARM Linux 2012-01-26 8:09 ` Marek Szyprowski 0 siblings, 1 reply; 4+ messages in thread From: Russell King - ARM Linux @ 2012-01-25 12:59 UTC (permalink / raw) To: Marek Szyprowski Cc: linux-arm-kernel, linaro-mm-sig, linux-mm, linux-arch, linux-samsung-soc, iommu, Kyungmin Park, Arnd Bergmann, Joerg Roedel, Shariq Hasnain, Chunsang Jeong, Krishna Reddy, KyongHo Cho, Andrzej Pietrasiewicz, Benjamin Herrenschmidt On Mon, Jan 09, 2012 at 04:49:21PM +0100, Marek Szyprowski wrote: > This patch add a complete implementation of DMA-mapping API for > devices that have IOMMU support. All DMA-mapping calls are supported. > > This patch contains some of the code kindly provided by Krishna Reddy > <vdumpa@nvidia.com> and Andrzej Pietrasiewicz <andrzej.p@samsung.com> > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > --- > > Hello, > > This is the corrected version of the previous patch from the "[PATCH 0/8 > v4] ARM: DMA-mapping framework redesign" thread which can be found here: > http://www.spinics.net/lists/linux-mm/msg27382.html > > Previous version had very nasty bug which causes memory trashing if > DMA-mapping managed to allocate pages larger than 4KiB. The problem was > in __iommu_alloc_buffer() function which did not check how many pages > has been left to allocate. This patch seems to be incomplete. If the standard DMA API is used (the one which exists in current kernels) and NEED_SG_DMA_LENGTH is enabled, then where do we set the DMA length in the scatterlist? > diff --git a/arch/arm/include/asm/dma-iommu.h b/arch/arm/include/asm/dma-iommu.h > new file mode 100644 > index 0000000..6668b41 > --- /dev/null > +++ b/arch/arm/include/asm/dma-iommu.h > @@ -0,0 +1,36 @@ > +#ifndef ASMARM_DMA_IOMMU_H > +#define ASMARM_DMA_IOMMU_H > + > +#ifdef __KERNEL__ > + > +#include <linux/mm_types.h> > +#include <linux/scatterlist.h> > +#include <linux/dma-debug.h> > +#include <linux/kmemcheck.h> > + > +#include <asm/memory.h> I can't see anything in here which needs asm/memory.h - if files which include this need it, please include it in there so we can see why it's needed. > + > +struct dma_iommu_mapping { > + /* iommu specific data */ > + struct iommu_domain *domain; > + > + void *bitmap; > + size_t bits; > + unsigned int order; > + dma_addr_t base; > + > + spinlock_t lock; > + struct kref kref; > +}; > + > +struct dma_iommu_mapping * > +arm_iommu_create_mapping(struct bus_type *bus, dma_addr_t base, size_t size, > + int order); > + > +void arm_iommu_release_mapping(struct dma_iommu_mapping *mapping); > + > +int arm_iommu_attach_device(struct device *dev, > + struct dma_iommu_mapping *mapping); > + > +#endif /* __KERNEL__ */ > +#endif > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c > index 4845c09..2287b01 100644 > --- a/arch/arm/mm/dma-mapping.c > +++ b/arch/arm/mm/dma-mapping.c > @@ -27,6 +27,9 @@ > #include <asm/sizes.h> > #include <asm/mach/arch.h> > > +#include <linux/iommu.h> linux/ includes should be grouped together. > diff --git a/arch/arm/mm/vmregion.h b/arch/arm/mm/vmregion.h > index 15e9f04..6bbc402 100644 > --- a/arch/arm/mm/vmregion.h > +++ b/arch/arm/mm/vmregion.h > @@ -17,7 +17,7 @@ struct arm_vmregion { > struct list_head vm_list; > unsigned long vm_start; > unsigned long vm_end; > - struct page *vm_pages; > + void *priv; I want to think about that - I may wish to export the vm_pages via the new dma-mappings file to provide additional information. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 8/8 RESEND] ARM: dma-mapping: add support for IOMMU mapper 2012-01-25 12:59 ` [PATCH 8/8 RESEND] " Russell King - ARM Linux @ 2012-01-26 8:09 ` Marek Szyprowski 0 siblings, 0 replies; 4+ messages in thread From: Marek Szyprowski @ 2012-01-26 8:09 UTC (permalink / raw) To: 'Russell King - ARM Linux' Cc: linux-arm-kernel, linaro-mm-sig, linux-mm, linux-arch, linux-samsung-soc, iommu, 'Kyungmin Park', 'Arnd Bergmann', 'Joerg Roedel', 'Shariq Hasnain', 'Chunsang Jeong', 'Krishna Reddy', 'KyongHo Cho', Andrzej Pietrasiewicz, 'Benjamin Herrenschmidt' Hello, On Wednesday, January 25, 2012 1:59 PM Russell King - ARM Linux wrote: > On Mon, Jan 09, 2012 at 04:49:21PM +0100, Marek Szyprowski wrote: > > This patch add a complete implementation of DMA-mapping API for > > devices that have IOMMU support. All DMA-mapping calls are supported. > > > > This patch contains some of the code kindly provided by Krishna Reddy > > <vdumpa@nvidia.com> and Andrzej Pietrasiewicz <andrzej.p@samsung.com> > > > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > > > --- > > > > Hello, > > > > This is the corrected version of the previous patch from the "[PATCH 0/8 > > v4] ARM: DMA-mapping framework redesign" thread which can be found here: > > http://www.spinics.net/lists/linux-mm/msg27382.html > > > > Previous version had very nasty bug which causes memory trashing if > > DMA-mapping managed to allocate pages larger than 4KiB. The problem was > > in __iommu_alloc_buffer() function which did not check how many pages > > has been left to allocate. > > This patch seems to be incomplete. > > If the standard DMA API is used (the one which exists in current kernels) > and NEED_SG_DMA_LENGTH is enabled, then where do we set the DMA length > in the scatterlist? Standard DMA API is also updated to work correctly with NEED_SG_DMA_LENGTH, please notice the following chunk: ----- @@ -644,6 +659,9 @@ int arm_dma_map_sg(struct device *dev, struct scatterlist *sg, int nents, int i, j; for_each_sg(sg, s, nents, i) { +#ifdef CONFIG_NEED_SG_DMA_LENGTH + s->dma_length = s->length; +#endif s->dma_address = ops->map_page(dev, sg_page(s), s->offset, s->length, dir, attrs); if (dma_mapping_error(dev, s->dma_address)) ----- (http://www.spinics.net/lists/arm-kernel/msg154889.html for the reference) > > diff --git a/arch/arm/include/asm/dma-iommu.h b/arch/arm/include/asm/dma-iommu.h > > new file mode 100644 > > index 0000000..6668b41 > > --- /dev/null > > +++ b/arch/arm/include/asm/dma-iommu.h > > @@ -0,0 +1,36 @@ > > +#ifndef ASMARM_DMA_IOMMU_H > > +#define ASMARM_DMA_IOMMU_H > > + > > +#ifdef __KERNEL__ > > + > > +#include <linux/mm_types.h> > > +#include <linux/scatterlist.h> > > +#include <linux/dma-debug.h> > > +#include <linux/kmemcheck.h> > > + > > +#include <asm/memory.h> > > I can't see anything in here which needs asm/memory.h - if files which > include this need it, please include it in there so we can see why it's > needed. Ok, I will fix this issue. > > > + > > +struct dma_iommu_mapping { > > + /* iommu specific data */ > > + struct iommu_domain *domain; > > + > > + void *bitmap; > > + size_t bits; > > + unsigned int order; > > + dma_addr_t base; > > + > > + spinlock_t lock; > > + struct kref kref; > > +}; > > + > > +struct dma_iommu_mapping * > > +arm_iommu_create_mapping(struct bus_type *bus, dma_addr_t base, size_t size, > > + int order); > > + > > +void arm_iommu_release_mapping(struct dma_iommu_mapping *mapping); > > + > > +int arm_iommu_attach_device(struct device *dev, > > + struct dma_iommu_mapping *mapping); > > + > > +#endif /* __KERNEL__ */ > > +#endif > > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c > > index 4845c09..2287b01 100644 > > --- a/arch/arm/mm/dma-mapping.c > > +++ b/arch/arm/mm/dma-mapping.c > > @@ -27,6 +27,9 @@ > > #include <asm/sizes.h> > > #include <asm/mach/arch.h> > > > > +#include <linux/iommu.h> > > linux/ includes should be grouped together. Ok, I will fix this. > > > diff --git a/arch/arm/mm/vmregion.h b/arch/arm/mm/vmregion.h > > index 15e9f04..6bbc402 100644 > > --- a/arch/arm/mm/vmregion.h > > +++ b/arch/arm/mm/vmregion.h > > @@ -17,7 +17,7 @@ struct arm_vmregion { > > struct list_head vm_list; > > unsigned long vm_start; > > unsigned long vm_end; > > - struct page *vm_pages; > > + void *priv; > > I want to think about that - I may wish to export the vm_pages via > the new dma-mappings file to provide additional information. For IOMMU case I need to store a page array for each allocated buffer. I haven't analyzed it yet, but maybe it would be possible to use standard vmalloc style entries and avoid creating separate arm_vmregion for coherent allocations? Best regards -- Marek Szyprowski Samsung Poland R&D Center ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-26 8:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1323448798-18184-1-git-send-email-m.szyprowski@samsung.com>
[not found] ` <1323448798-18184-9-git-send-email-m.szyprowski@samsung.com>
2012-01-25 12:47 ` [PATCH 8/8] ARM: dma-mapping: add support for IOMMU mapper Hiroshi Doyu
2012-01-26 7:46 ` Marek Szyprowski
[not found] ` <1326124161-2220-1-git-send-email-m.szyprowski@samsung.com>
2012-01-25 12:59 ` [PATCH 8/8 RESEND] " Russell King - ARM Linux
2012-01-26 8:09 ` Marek Szyprowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).