* [PATCH] iommu/tegra-gart: fix spin_unlock in map failure path
@ 2012-03-12 19:15 Lucas Stach
2012-03-13 6:37 ` Hiroshi Doyu
2012-03-13 10:29 ` Joerg Roedel
0 siblings, 2 replies; 3+ messages in thread
From: Lucas Stach @ 2012-03-12 19:15 UTC (permalink / raw)
To: Joerg Roedel; +Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA
This must have been messed up while merging, the intention was
clearly to unlock there.
Signed-off-by: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
---
drivers/iommu/tegra-gart.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/iommu/tegra-gart.c b/drivers/iommu/tegra-gart.c
index b21598f..779306e 100644
--- a/drivers/iommu/tegra-gart.c
+++ b/drivers/iommu/tegra-gart.c
@@ -246,7 +246,7 @@ static int gart_iommu_map(struct iommu_domain *domain, unsigned long iova,
pfn = __phys_to_pfn(pa);
if (!pfn_valid(pfn)) {
dev_err(gart->dev, "Invalid page: %08x\n", pa);
- spin_lock_irqsave(&gart->pte_lock, flags);
+ spin_unlock_irqrestore(&gart->pte_lock, flags);
return -EINVAL;
}
gart_set_pte(gart, iova, GART_PTE(pfn));
--
1.7.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu/tegra-gart: fix spin_unlock in map failure path
2012-03-12 19:15 [PATCH] iommu/tegra-gart: fix spin_unlock in map failure path Lucas Stach
@ 2012-03-13 6:37 ` Hiroshi Doyu
2012-03-13 10:29 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Hiroshi Doyu @ 2012-03-13 6:37 UTC (permalink / raw)
To: Lucas Stach, Joerg Roedel
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Hi Lucas,
On Mon, 12 Mar 2012 20:15:01 +0100
Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org> wrote:
> This must have been messed up while merging, the intention was
> clearly to unlock there.
>
> Signed-off-by: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
Good catch. Thanks.
Joerg, Could you put this one on your queue?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu/tegra-gart: fix spin_unlock in map failure path
2012-03-12 19:15 [PATCH] iommu/tegra-gart: fix spin_unlock in map failure path Lucas Stach
2012-03-13 6:37 ` Hiroshi Doyu
@ 2012-03-13 10:29 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Joerg Roedel @ 2012-03-13 10:29 UTC (permalink / raw)
To: Lucas Stach; +Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA
On Mon, Mar 12, 2012 at 08:15:01PM +0100, Lucas Stach wrote:
> This must have been messed up while merging, the intention was
> clearly to unlock there.
>
> Signed-off-by: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
Applied to arm/tegra, thanks Lucas. Hope to see you in Chemnitz this
weekend :-)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-13 10:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-12 19:15 [PATCH] iommu/tegra-gart: fix spin_unlock in map failure path Lucas Stach
2012-03-13 6:37 ` Hiroshi Doyu
2012-03-13 10:29 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).