From: Ingo Molnar <mingo@kernel.org>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: joro@8bytes.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org,
Joerg Roedel <joerg.roedel@amd.com>
Subject: Re: [PATCH 3/3] irq_remap: fix the 'sub_handle' uninitialized warning
Date: Tue, 8 May 2012 11:15:26 +0200 [thread overview]
Message-ID: <20120508091526.GD27323@gmail.com> (raw)
In-Reply-To: <1336460934-23592-3-git-send-email-suresh.b.siddha@intel.com>
another problem is that drivers/iommu/intel_irq_remapping.c is
supplied with comments rather poorly - I have to page down
almost 300 lines to see the first substantial comment! Copyright
notices would be nice as well.
So lets do a better job and document this thing a bit better.
Please also align structure definitions vertically, like we
typically to do in new code.
The file names should probably also be standardized (but that
should come via a Git space pull request, using git mv and
such). What we have currently is pretty random: 'dmar.c' should
probably be dma_remap.c, and *irq_remapping.c should probably be
*irq_remap.c.
Thanks,
Ingo
prev parent reply other threads:[~2012-05-08 9:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 13:54 [git pull] irq remapping ops for x86 Joerg Roedel
2012-05-08 3:51 ` Ingo Molnar
[not found] ` <20120508035153.GA30652-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-05-08 7:08 ` [PATCH 1/3] irq_remap: fix compiler warning with !CONFIG_IRQ_REMAP Suresh Siddha
[not found] ` <1336460934-23592-1-git-send-email-suresh.b.siddha-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2012-05-08 7:08 ` [PATCH 2/3] irq_remap: fix the UP build failure Suresh Siddha
2012-05-08 9:09 ` Ingo Molnar
[not found] ` <20120508090945.GC27323-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-05-09 2:37 ` Suresh Siddha
2012-05-09 9:30 ` Ingo Molnar
2012-05-08 7:08 ` [PATCH 3/3] irq_remap: fix the 'sub_handle' uninitialized warning Suresh Siddha
2012-05-08 9:15 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120508091526.GD27323@gmail.com \
--to=mingo@kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joerg.roedel@amd.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).