From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 3/3] irq_remap: fix the 'sub_handle' uninitialized warning Date: Tue, 8 May 2012 11:15:26 +0200 Message-ID: <20120508091526.GD27323@gmail.com> References: <20120508035153.GA30652@gmail.com> <1336460934-23592-3-git-send-email-suresh.b.siddha@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1336460934-23592-3-git-send-email-suresh.b.siddha@intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Suresh Siddha Cc: joro@8bytes.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Joerg Roedel List-Id: iommu@lists.linux-foundation.org another problem is that drivers/iommu/intel_irq_remapping.c is supplied with comments rather poorly - I have to page down almost 300 lines to see the first substantial comment! Copyright notices would be nice as well. So lets do a better job and document this thing a bit better. Please also align structure definitions vertically, like we typically to do in new code. The file names should probably also be standardized (but that should come via a Git space pull request, using git mv and such). What we have currently is pretty random: 'dmar.c' should probably be dma_remap.c, and *irq_remapping.c should probably be *irq_remap.c. Thanks, Ingo