From: Greg KH <gregkh@linuxfoundation.org>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: benh@kernel.crashing.org, aik@ozlabs.ru,
david@gibson.dropbear.id.au, joerg.roedel@amd.com,
dwmw2@infradead.org, chrisw@sous-sol.org, agraf@suse.de,
benve@cisco.com, aafabbri@cisco.com, B08248@freescale.com,
B07421@freescale.com, avi@redhat.com, konrad.wilk@oracle.com,
kvm@vger.kernel.org, qemu-devel@nongnu.org,
iommu@lists.linux-foundation.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, bhelgaas@google.com
Subject: Re: [PATCH 01/13] driver core: Add iommu_group tracking to struct device
Date: Fri, 11 May 2012 17:00:40 -0700 [thread overview]
Message-ID: <20120512000040.GA17559@kroah.com> (raw)
In-Reply-To: <1336780681.12477.198.camel@bling.home>
On Fri, May 11, 2012 at 05:58:01PM -0600, Alex Williamson wrote:
> On Fri, 2012-05-11 at 16:38 -0700, Greg KH wrote:
> > On Fri, May 11, 2012 at 04:55:35PM -0600, Alex Williamson wrote:
> > > IOMMU groups allow IOMMU drivers to represent DMA visibility
> > > and isolation of devices. Multiple devices may be grouped
> > > together for the purposes of DMA. Placing a pointer on
> > > struct device enable easy access for things like streaming
> > > DMA programming and drivers like VFIO.
> > >
> > > Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> >
> > Can't you get this today from the iommu_ops pointer that is on the bus
> > that the device is associated with? Or can devices on a bus have
> > different iommu_group pointers?
>
> The latter, each device on a bus might be it's own group. This is often
> the case on x86 unless PCIe-to-PCI bridges obscure the device
> visibility. Thanks,
Ah, ok, then I have no objection to add this to struct device:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2012-05-12 0:00 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 22:55 [PATCH 00/13] IOMMU Groups + VFIO Alex Williamson
[not found] ` <20120511222148.30496.68571.stgit-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2012-05-11 22:55 ` [PATCH 01/13] driver core: Add iommu_group tracking to struct device Alex Williamson
2012-05-11 23:38 ` Greg KH
[not found] ` <20120511233821.GA9335-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2012-05-11 23:58 ` Alex Williamson
2012-05-12 0:00 ` Greg KH [this message]
2012-05-11 22:55 ` [PATCH 02/13] iommu: IOMMU Groups Alex Williamson
2012-05-11 23:39 ` Greg KH
[not found] ` <20120511233950.GB9335-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2012-05-11 23:58 ` Alex Williamson
[not found] ` <20120511225541.30496.34751.stgit-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2012-05-14 1:16 ` David Gibson
[not found] ` <20120514011627.GB30229-MK4v0fQdeXQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-05-14 17:11 ` Alex Williamson
[not found] ` <1337015502.6954.68.camel-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2012-05-15 2:03 ` David Gibson
[not found] ` <20120515020328.GG30229-MK4v0fQdeXQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-05-15 6:34 ` Alex Williamson
[not found] ` <1337063643.6954.166.camel-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2012-05-17 3:29 ` David Gibson
2012-05-11 22:55 ` [PATCH 03/13] iommu: IOMMU groups for VT-d and AMD-Vi Alex Williamson
[not found] ` <20120511225548.30496.34428.stgit-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2012-05-17 3:37 ` David Gibson
2012-05-11 22:55 ` [PATCH 04/13] pci: New pci_dma_quirk() Alex Williamson
[not found] ` <20120511225555.30496.80525.stgit-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2012-05-17 3:39 ` David Gibson
[not found] ` <20120517033914.GF22069-MK4v0fQdeXQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-05-17 4:06 ` Alex Williamson
2012-05-17 7:19 ` Anonymous
[not found] ` <CAJtEV7YMrsttPfAdL0_uht-ZRwCHhYwHTvypCc6TfEzTEGaijQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-17 15:22 ` Alex Williamson
2012-05-11 22:56 ` [PATCH 05/13] pci: New pci_acs_enabled() Alex Williamson
[not found] ` <20120511225602.30496.80438.stgit-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2012-05-14 22:02 ` Bjorn Helgaas
[not found] ` <CAErSpo58hKPFb5duOi64sWuR5AJDTVp0rRHkQLotYE3CMXRRhA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-14 22:49 ` Alex Williamson
[not found] ` <1337035766.6954.74.camel-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2012-05-15 19:56 ` Bjorn Helgaas
[not found] ` <CAErSpo48ES5iLDCh1WzmHezSEYhPjhtgD5uxoY-TCTKgUBab2g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-15 20:05 ` Bjorn Helgaas
2012-05-15 21:09 ` Alex Williamson
[not found] ` <1337116157.6954.212.camel-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2012-05-16 13:29 ` Don Dutile
[not found] ` <4FB3ABCF.4030708-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-05-16 16:21 ` Alex Williamson
[not found] ` <1337185318.6954.243.camel-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2012-05-16 19:36 ` Alex Williamson
2012-05-18 23:00 ` RESEND3: " Don Dutile
[not found] ` <4FB6D47C.4010003-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-05-19 2:47 ` Alex Williamson
[not found] ` <1337395622.28883.43.camel-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2012-05-21 13:31 ` Don Dutile
[not found] ` <4FBA43C9.1080509-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-05-21 14:59 ` Alex Williamson
[not found] ` <1337612353.28883.66.camel-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2012-05-21 18:14 ` Don Dutile
2012-05-11 22:56 ` [PATCH 06/13] iommu: Make use of DMA quirking and ACS enabled check for groups Alex Williamson
2012-05-11 22:56 ` [PATCH 07/13] vfio: VFIO core Alex Williamson
2012-05-11 22:56 ` [PATCH 08/13] vfio: Add documentation Alex Williamson
2012-05-11 22:56 ` [PATCH 09/13] vfio: x86 IOMMU implementation Alex Williamson
2012-05-11 22:56 ` [PATCH 10/13] pci: export pci_user functions for use by other drivers Alex Williamson
[not found] ` <20120511225636.30496.26907.stgit-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2012-05-14 21:20 ` Bjorn Helgaas
2012-05-11 22:56 ` [PATCH 11/13] pci: Create common pcibios_err_to_errno Alex Williamson
[not found] ` <20120511225643.30496.36823.stgit-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2012-05-21 17:55 ` Konrad Rzeszutek Wilk
2012-05-11 22:56 ` [PATCH 12/13] pci: Misc pci_reg additions Alex Williamson
2012-05-11 22:56 ` [PATCH 13/13] vfio: Add PCI device driver Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120512000040.GA17559@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=B07421@freescale.com \
--cc=B08248@freescale.com \
--cc=aafabbri@cisco.com \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=avi@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=benve@cisco.com \
--cc=bhelgaas@google.com \
--cc=chrisw@sous-sol.org \
--cc=david@gibson.dropbear.id.au \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joerg.roedel@amd.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).