From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 1/2] resources: set type of new resource returned by __request_region() Date: Wed, 23 May 2012 12:40:09 +0200 Message-ID: <20120523104009.GD12795@8bytes.org> References: <20120518231238.31187.44571.stgit@bhelgaas.mtv.corp.google.com> <20120518231832.31187.10630.stgit@bhelgaas.mtv.corp.google.com> <20120521130451.GK2313@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Bjorn Helgaas Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Ingo Molnar , David Woodhouse , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Suresh Siddha List-Id: iommu@lists.linux-foundation.org On Mon, May 21, 2012 at 07:52:24AM -0600, Bjorn Helgaas wrote: > On Mon, May 21, 2012 at 7:04 AM, Joerg Roedel wrote: > > On Fri, May 18, 2012 at 05:18:32PM -0600, Bjorn Helgaas wrote: > >> Previously we returned a new struct resource with only IORESOURCE_BUSY > >> set (and possibly IORESOURCE_MUXED or IORESOURCE_EXCLUSIVE), but no > >> MEM/IO/etc. bits set. =A0The new resource should inherit the type of > >> its parent. > > > > Should it? What about IORESOURCE_WINDOW for example? Any particular > > reason for this change to the interface of the __request_region() > > function? > = > Yes, I should have explained the connection :) The next patch prints > the resource returned from request_mem_region(). Without this > __request_region() patch, that resource has no type, so %pR can't > print it correctly. > = > Good question about IORESOURCE_WINDOW. Maybe it should inherit only > the IORESOURCE_TYPE_BITS part (IO/MEM/IRQ/DMA/BUS). But it seemed > like it should also inherit PREFETCH, READONLY, CACHEABLE, etc. Maybe > we should inherit everything but clear IORESOURCE_WINDOW? I'm open to > suggestions here. I am still not sure whether the inheritance is a good idea. How about changing the define of request_mem_region to: #define request_mem_region(start,n,name) __request_region(&iomem_resource, = (start), (n), (name), IORESOURCE_MEM) ? Joerg