[PATCH 1/2] iommu: Include linux/types.h

[PATCH 1/2] iommu: Include linux/types.h

[Thierry Reding]

The linux/iommu.h header uses types defined in linux/types.h but doesn't
include it.

Signed-off-by: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
---
 include/linux/iommu.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index a71df92..9cbcc6a 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -20,6 +20,7 @@
 #define __LINUX_IOMMU_H
 
 #include <linux/errno.h>
+#include <linux/types.h>
 
 #define IOMMU_READ	(1)
 #define IOMMU_WRITE	(2)
-- 
1.7.11.2

[PATCH 2/2] iommu: Include linux/notifier.h

[Thierry Reding]

The linux/iommu.h header uses types defined in linux/notifier.h but
doesn't include it.

Signed-off-by: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
---
 include/linux/iommu.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 9cbcc6a..4f64020 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -20,6 +20,7 @@
 #define __LINUX_IOMMU_H
 
 #include <linux/errno.h>
+#include <linux/notifier.h>
 #include <linux/types.h>
 
 #define IOMMU_READ	(1)
-- 
1.7.11.2

Re: [PATCH 2/2] iommu: Include linux/notifier.h

[Joerg Roedel]

On Wed, Jul 25, 2012 at 04:24:50PM +0200, Thierry Reding wrote:
> The linux/iommu.h header uses types defined in linux/notifier.h but
> doesn't include it.
> 
> Signed-off-by: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>

Better than adding the header-file is to add a forward declaration for
struct notifier_block. I added a patch to iommu/fixes for this.

Thanks,

	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

Re: [PATCH 2/2] iommu: Include linux/notifier.h

[Thierry Reding]

[-- Attachment #1.1: Type: text/plain, Size: 522 bytes --]

On Fri, Aug 03, 2012 at 04:08:26PM +0200, Joerg Roedel wrote:
> On Wed, Jul 25, 2012 at 04:24:50PM +0200, Thierry Reding wrote:
> > The linux/iommu.h header uses types defined in linux/notifier.h but
> > doesn't include it.
> > 
> > Signed-off-by: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
> 
> Better than adding the header-file is to add a forward declaration for
> struct notifier_block. I added a patch to iommu/fixes for this.

Yes, that would also work.

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 190 bytes --]

_______________________________________________
iommu mailing list
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 1/2] iommu: Include linux/types.h

[Joerg Roedel]

On Wed, Jul 25, 2012 at 04:24:49PM +0200, Thierry Reding wrote:
> The linux/iommu.h header uses types defined in linux/types.h but doesn't
> include it.
> 
> Signed-off-by: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>

Applied to iommu/fixes, thanks Thierry.

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632