From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 08/16] iommu/amd: Add routines to manage irq remapping tables Date: Fri, 28 Sep 2012 17:01:34 +0200 Message-ID: <20120928150134.GH4009@amd.com> References: <1348835046-3262-1-git-send-email-joerg.roedel@amd.com> <1348835046-3262-9-git-send-email-joerg.roedel@amd.com> <20120928144011.GF7483@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20120928144011.GF7483-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Konrad Rzeszutek Wilk Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Fri, Sep 28, 2012 at 10:40:13AM -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Sep 28, 2012 at 02:23:58PM +0200, Joerg Roedel wrote: > > + irte_info = &cfg->irq_2_iommu; > > + irte_info->sub_handle = devid; > > + irte_info->irte_index = index; > > Should the irte_info also contain the count information to know how > whether the table->table[index] (which would be IRTE_ALLOCATED at > this point) is owned by correct irte_info ? No, because the irte_info used here is only for the first index. For the following indexes up to index+count-1 other irte_info structs are used. This is necessary because of the way MSI-X interrupts are set up with interrupt remapping. Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632