From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Nieder Subject: Re: [PATCH -stable] amd_iommu: attach device fails on the last pci device Date: Fri, 12 Oct 2012 11:38:28 -0700 Message-ID: <20121012183828.GA16453@elie.Belkin> References: <1350059367.2643.17.camel@lorien2> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1350059367.2643.17.camel@lorien2> Sender: linux-kernel-owner@vger.kernel.org To: Shuah Khan Cc: joerg.roedel@amd.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, Greg KH , iommu@lists.linux-foundation.org, stable@vger.kernel.org, x86@kernel.org, LKML , shuahkhan@gmail.com List-Id: iommu@lists.linux-foundation.org Shuah Khan wrote: > This bug is in linux-2.6.32 and an equivalent fix in linux-2.6.33 and has been > carried forward to later kernels and is in the upstream kernel. This equivalent > fix includes restructuring and consolidating device checks into a routine > check_device(). Instead of back-porting all of that work, spot-fixed the bug in > amd_iommu_attach_device() for linux-2.6.32. To save Willy time: am I correct in guessing the upstream commit you are referring to is 98fc5a693bbdda498a556654c70d1e31a186c988 (x86/amd-iommu: Use get_device_id and check_device where appropriate, 2009-11-24)? Thanks, Jonathan