From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 1/1] iommuv2/amd: Enable Performance Counters On Family 15h Models 10h-1Fh Date: Thu, 6 Dec 2012 11:32:38 +0100 Message-ID: <20121206103238.GF1806@8bytes.org> References: <1354659546-9700-1-git-send-email-steven.kinney@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1354659546-9700-1-git-send-email-steven.kinney-5C7GfCeVMHo@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Steven Kinney Cc: Kukjin Kim , Stephen Warren , Jiri Kosina , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Tue, Dec 04, 2012 at 04:19:06PM -0600, Steven Kinney wrote: > drivers/iommu/Kconfig | 10 +++++ > drivers/iommu/amd_iommu_init.c | 85 +++++++++++++++++++++++++++++++++++++++ > drivers/iommu/amd_iommu_types.h | 13 +++++- > 3 files changed, 107 insertions(+), 1 deletion(-) So first of all, this patch alone doesn't make sense. You should submit it in a patch-set that enabled IOMMUv2 performance counters for the end-user. This means together with the PMU implementation and tools support. Further I don't see how this patch is specific to Family 15h Models 10h-1Fh as described in the subject-line. Any comments on these two points? Cheers, Joerg