From: Stephen Hemminger <stephen@networkplumber.org>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>,
iommu@lists.linux-foundation.org
Subject: Re: PCI warning on boot 3.8.0-rc1
Date: Mon, 4 Feb 2013 17:36:10 -0800 [thread overview]
Message-ID: <20130204173610.18a31d24@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1360017684.11144.547.camel@bling.home>
On Mon, 04 Feb 2013 15:41:24 -0700
Alex Williamson <alex.williamson@redhat.com> wrote:
> +
> + if (pci_is_pcie(parent) &&
> + (pci_pcie_type(parent) == PCI_EXP_TYPE_ROOT_PORT ||
> + pci_pcie_type(parent) == PCI_EXP_TYPE_DOWNSTREAM)) {
> + pr_warn("WARNING: Your hardware is broken, device %s appears to be a\n Legacy PCI device attached directly to a PCIe device which is not a\n PCIe-to-PCI bridge. Per section 7.8 of the PCI Express 3.0 spec, the\n PCI express capability structure is required for PCI express device\nfunctions.\n",
> + pci_name(pdev));
Too whiny!
Two short lines seems to be more the enough. Users can't do anything about
hardware not following spec. Put any outher stuff into comments.
next prev parent reply other threads:[~2013-02-05 1:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130116143853.339dd89b@nehalam.linuxnetplumber.net>
2013-01-30 21:59 ` PCI warning on boot 3.8.0-rc1 Bjorn Helgaas
2013-02-04 18:36 ` Stephen Hemminger
[not found] ` <20130204103645.38ae2d5e-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>
2013-02-04 20:28 ` Alex Williamson
2013-02-04 20:30 ` Stephen Hemminger
[not found] ` <20130204123041.31e402df-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>
2013-02-04 20:36 ` Alex Williamson
[not found] ` <1360009684.11144.539.camel-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2013-02-04 22:41 ` Alex Williamson
2013-02-05 1:36 ` Stephen Hemminger [this message]
2013-02-06 15:49 ` Stephen Hemminger
[not found] ` <20130206074900.02f04e3f-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>
2013-02-06 15:58 ` Alex Williamson
2013-02-12 4:15 ` Alex Williamson
2013-02-12 18:33 ` Stephen Hemminger
2013-04-10 22:36 ` Bjorn Helgaas
[not found] ` <20130410223650.GA6109-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2013-04-11 0:01 ` Alex Williamson
2013-04-11 17:23 ` Bjorn Helgaas
[not found] ` <CAErSpo4Nn9wsoaNxKZbHfU79w1t9C9Y3iHei5_bJpPjRZHSAow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-15 19:12 ` Alex Williamson
[not found] ` <1366053154.2918.180.camel-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2013-04-15 19:29 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204173610.18a31d24@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox