From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Takao Indoh <indou.takao-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
Cc: kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] intel-iommu: Synchronize gcmd value with global command register
Date: Tue, 2 Apr 2013 16:05:47 +0200 [thread overview]
Message-ID: <20130402140546.GA15687@8bytes.org> (raw)
In-Reply-To: <51591EEE.60401-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
On Mon, Apr 01, 2013 at 02:45:18PM +0900, Takao Indoh wrote:
> <Current flow on kdump boot>
> enable_IR
> intel_enable_irq_remapping
> iommu_disable_irq_remapping <== IRES/QIES/TES disabled here
> dmar_disable_qi <== do nothing
> dmar_enable_qi <== QIES enabled
> intel_setup_irq_remapping <== IRES enabled
But what we want to do here in the kdumo case is to disable translation
too, right? Because the former kernel might have translation and
irq-remapping enabled and the kdump kernel might be compiled without
support for dma-remapping. So if we don't disable translation here too
the kdump kernel is unable to do DMA.
I agree that disabling translation should be a bit more explicit instead
of the current code.
Joerg
next prev parent reply other threads:[~2013-04-02 14:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 1:32 [PATCH] intel-iommu: Synchronize gcmd value with global command register Takao Indoh
[not found] ` <1363829556-2128-1-git-send-email-indou.takao-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-03-26 14:46 ` Joerg Roedel
[not found] ` <20130326144629.GB2727-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-03-27 5:02 ` Takao Indoh
[not found] ` <51527D74.9080209-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-03-27 10:31 ` Joerg Roedel
[not found] ` <20130327103122.GK30540-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-04-01 5:45 ` Takao Indoh
[not found] ` <51591EEE.60401-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-04-02 14:05 ` Joerg Roedel [this message]
[not found] ` <20130402140546.GA15687-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-04-03 7:11 ` Takao Indoh
2013-04-03 8:24 ` David Woodhouse
[not found] ` <1364977479.28127.15.camel-W2I5cNIroUsVm/YvaOjsyQ@public.gmane.org>
2013-04-04 5:48 ` Takao Indoh
[not found] ` <515D1429.40707-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-04-04 14:24 ` David Woodhouse
2013-04-08 8:57 ` Takao Indoh
2013-04-05 11:06 ` Joerg Roedel
[not found] ` <20130405110616.GB6858-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-04-10 4:47 ` Takao Indoh
[not found] ` <5164EEE6.8000707-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-04-15 9:00 ` Takao Indoh
[not found] ` <516BC19D.4090303-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-04-15 10:18 ` Joerg Roedel
[not found] ` <20130415101829.GP6858-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-04-17 8:48 ` Takao Indoh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402140546.GA15687@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=indou.takao-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).