From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Suravee Suthikulanit
<suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V3] iommu/amd: Add logic to decode AMD IOMMU event flag
Date: Tue, 9 Apr 2013 21:52:31 +0200 [thread overview]
Message-ID: <20130409195231.GI6858@8bytes.org> (raw)
In-Reply-To: <51642FCD.8080606-5C7GfCeVMHo@public.gmane.org>
On Tue, Apr 09, 2013 at 10:12:13AM -0500, Suthikulpanit, Suravee wrote:
> These messages are not "high volumn". What I am trying to achieve
> is for users to be able to just send the errors to developers once
> they are encountered without having to tell them to go back and
> reboot with the "amd_iommu=verbose". In facts, they often difficult
> to reproduce from my experience. This should reduce the amount of
> communications and efforts required to debug the issue.
More than one line per io-page-fault _is_ high volume. The current code
that prints only one line was sufficient to debug all related AMD IOMMU
driver problems in the past 5 years I am working on this driver.
What makes sense is decoding the flags field in the kernel. Doing this
by hand always costs some time that could be saved this way. If your
patch does more than that by default I am not going to merge it.
Joerg
prev parent reply other threads:[~2013-04-09 19:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 0:06 [PATCH V3] iommu/amd: Add logic to decode AMD IOMMU event flag suravee.suthikulpanit
2013-04-08 14:33 ` Suthikulpanit, Suravee
[not found] ` <02D2024799561B48A732D1A51CB969E81959AF3E-Vo+W8YXarrhLxsqq04mzcUEOCMrvLtNR@public.gmane.org>
2013-04-08 14:50 ` Borislav Petkov
[not found] ` <20130408145003.GC4723-fF5Pk5pvG8Y@public.gmane.org>
2013-04-08 15:43 ` Suravee Suthikulanit
[not found] ` <5162E5B1.2030707-5C7GfCeVMHo@public.gmane.org>
2013-04-08 18:48 ` Borislav Petkov
[not found] ` <1364947610-3327-1-git-send-email-suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2013-04-09 9:41 ` Joerg Roedel
[not found] ` <20130409094132.GD6858-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-04-09 15:12 ` Suravee Suthikulanit
[not found] ` <51642FCD.8080606-5C7GfCeVMHo@public.gmane.org>
2013-04-09 19:52 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130409195231.GI6858@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).