From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Wei Yongjun <weiyj.lk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH -next] iommu/amd: fix error return code in early_amd_iommu_init()
Date: Tue, 23 Apr 2013 14:38:40 +0200 [thread overview]
Message-ID: <20130423123839.GB2589@8bytes.org> (raw)
In-Reply-To: <CAPgLHd9shRmpq__avgWPupFvcY2LNuEtPs9bG=AVpBx7BpLZTw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Tue, Apr 23, 2013 at 10:47:44AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
>
> Fix to return -ENOMEM int the memory alloc error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
> ---
> drivers/iommu/amd_iommu_init.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
> index 9110c1c..a55ec50 100644
> --- a/drivers/iommu/amd_iommu_init.c
> +++ b/drivers/iommu/amd_iommu_init.c
> @@ -1860,6 +1860,7 @@ static int __init early_amd_iommu_init(void)
> * Interrupt remapping enabled, create kmem_cache for the
> * remapping tables.
> */
> + ret = -ENOMEM;
> amd_iommu_irq_cache = kmem_cache_create("irq_remap_cache",
> MAX_IRQS_PER_TABLE * sizeof(u32),
> IRQ_TABLE_ALIGNMENT,
>
Applied to x86/amd, thanks.
prev parent reply other threads:[~2013-04-23 12:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 2:47 [PATCH -next] iommu/amd: fix error return code in early_amd_iommu_init() Wei Yongjun
[not found] ` <CAPgLHd9shRmpq__avgWPupFvcY2LNuEtPs9bG=AVpBx7BpLZTw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-23 12:38 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130423123839.GB2589@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=weiyj.lk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).