From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH 1/9] iommu/arm-smmu: Switch to arch_initcall for driver registration Date: Fri, 27 Sep 2013 09:58:12 +0100 Message-ID: <20130927085811.GD8319@mudshark.cambridge.arm.com> References: <1380234982-1677-1-git-send-email-andreas.herrmann@calxeda.com> <1380234982-1677-2-git-send-email-andreas.herrmann@calxeda.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1380234982-1677-2-git-send-email-andreas.herrmann-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Andreas Herrmann Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , Rob Herring , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: iommu@lists.linux-foundation.org On Thu, Sep 26, 2013 at 11:36:13PM +0100, Andreas Herrmann wrote: > This should ensure that arm-smmu is initialized before other drivers > start handling devices that propably need smmu support. > > Also remove module_exit function as we most likely never want to > unload this driver. Doesn't hurt to leave the exit function there though, right? > Signed-off-by: Andreas Herrmann > --- > drivers/iommu/arm-smmu.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index 181c9ba..6808577 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -1976,13 +1976,7 @@ static int __init arm_smmu_init(void) > return 0; > } > > -static void __exit arm_smmu_exit(void) > -{ > - return platform_driver_unregister(&arm_smmu_driver); > -} > - > -module_init(arm_smmu_init); > -module_exit(arm_smmu_exit); > +arch_initcall(arm_smmu_init); Why not subsys_initcall, like the other ARM IOMMUs? Will