From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH v2] ARM: SMMU: add devices attached to the SMMU to an IOMMU group Date: Tue, 29 Oct 2013 04:32:41 +0000 Message-ID: <20131029043240.GE22291@mudshark.cambridge.arm.com> References: <1382108910-18049-1-git-send-email-a.motakis@virtualopensystems.com> <1382978662.4097.35.camel@ul30vt.home> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1382978662.4097.35.camel-85EaTFmN5p//9pzu0YdTqQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Alex Williamson Cc: open list , "open list:IOMMU DRIVERS" , Antonios Motakis , "tech-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org" , "kvmarm-FPEHb7Xf0XXUo1n7N8X6UoWGPAHP3yOg@public.gmane.org" , "moderated list:ARM SMMU DRIVER" List-Id: iommu@lists.linux-foundation.org On Mon, Oct 28, 2013 at 04:44:22PM +0000, Alex Williamson wrote: > On Fri, 2013-10-18 at 17:08 +0200, Antonios Motakis wrote: > > IOMMU groups are expected by certain users of the IOMMU API, > > e.g. VFIO. Add new devices found by the SMMU driver to an IOMMU > > group to satisfy those users. > > > > Changes from v1: > > * Added check that dev->archdata.iommu has not been set already by an IOMMU > > driver. This way we can also skip checking for an existing IOMMU group. > > > > Signed-off-by: Antonios Motakis > > > Looks ok to me. > > Acked-by: Alex Williamson Yup, looks fine to me too. I'm travelling until next week, so I'll start picking things up then. Cheers, Will