From: Marcelo Tosatti <mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Greg Edwards <gedwards-LfVdkaOWEx8@public.gmane.org>
Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
"kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: intel-iommu: iova_to_phys: fill in bits from iova when large pte
Date: Mon, 4 Nov 2013 18:15:12 -0200 [thread overview]
Message-ID: <20131104201512.GA15760@amt.cnet> (raw)
In-Reply-To: <20131104170754.GA7317@psuche>
On Mon, Nov 04, 2013 at 10:07:54AM -0700, Greg Edwards wrote:
> On Fri, Nov 01, 2013 at 06:45:12PM -0700, Marcelo Tosatti wrote:
> >
> > intel_iommu_iova_to_phys returns incorrect physical address
> > when iova is translated by large pte.
> >
> > Fill in bits from iova when creating the physical address.
>
> Marcelo, for what it's worth, this patch alone didn't fix the BUG when
> using KVM PCI assignment with huge pages. I still needed the hva
> alignment patch as well.
>
> Greg
Yep, still a bugfix though.
Good catch, Greg.
prev parent reply other threads:[~2013-11-04 20:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-02 1:45 intel-iommu: iova_to_phys: fill in bits from iova when large pte Marcelo Tosatti
[not found] ` <20131102014511.GA29838-I4X2Mt4zSy4@public.gmane.org>
2013-11-04 17:07 ` Greg Edwards
2013-11-04 20:15 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131104201512.GA15760@amt.cnet \
--to=mtosatti-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=gedwards-LfVdkaOWEx8@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).