From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: Re: [GIT PULL] iommu/arm-smmu: fixes for 3.14
Date: Thu, 20 Feb 2014 13:14:26 +0100 [thread overview]
Message-ID: <20140220121426.GH11432@8bytes.org> (raw)
In-Reply-To: <20140220115127.GH3615-MRww78TxoiP5vMa5CHWGZ34zcgK1vI+I0E9HWUfgJXw@public.gmane.org>
Hi Will,
On Thu, Feb 20, 2014 at 11:51:27AM +0000, Will Deacon wrote:
> > Can the arm_smmu_devices_lock also be used in a DMA-API path?
>
> I don't think so -- that lock is only taken when:
>
> - Probing the SMMU
> - Attaching a device to a domain (->attach_dev)
> - Adding or removing a device to/from the SMMU (->{add,remove}_device)
Okay, fine then.
>
> > I also think that the parameter renaming should not be done in a fixup
> > patch, if you want it to be converted please include a renaming patch in
> > your updates for the next merge window.
>
> Sure, that's just a cosmetic thing anyway.
> For your patch below,
>
> Acked-by: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
Thanks, I queued the patch with your Ack ontop of the fixes and will
send them out to Linus after a day in next or so.
Cheers,
Joerg
prev parent reply other threads:[~2014-02-20 12:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 18:32 [GIT PULL] iommu/arm-smmu: fixes for 3.14 Will Deacon
[not found] ` <20140210183232.GH12826-MRww78TxoiP5vMa5CHWGZ34zcgK1vI+I0E9HWUfgJXw@public.gmane.org>
2014-02-18 11:27 ` Joerg Roedel
2014-02-18 17:50 ` Joerg Roedel
[not found] ` <20140218175027.GE11432-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-02-18 18:36 ` Will Deacon
[not found] ` <20140218183626.GC2010-MRww78TxoiP5vMa5CHWGZ34zcgK1vI+I0E9HWUfgJXw@public.gmane.org>
2014-02-18 19:21 ` Will Deacon
[not found] ` <20140218192137.GJ2010-MRww78TxoiP5vMa5CHWGZ34zcgK1vI+I0E9HWUfgJXw@public.gmane.org>
2014-02-20 11:29 ` Joerg Roedel
[not found] ` <20140220112919.GG11432-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-02-20 11:51 ` Will Deacon
[not found] ` <20140220115127.GH3615-MRww78TxoiP5vMa5CHWGZ34zcgK1vI+I0E9HWUfgJXw@public.gmane.org>
2014-02-20 12:14 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140220121426.GH11432@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox