From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: Laurent Pinchart
<laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 1/2] iommu/arm-smmu: Replace list walk with platform driver data
Date: Fri, 28 Feb 2014 16:38:37 +0000 [thread overview]
Message-ID: <20140228163837.GC30996@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1393601830-4677-2-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
Hi Laurent,
On Fri, Feb 28, 2014 at 03:37:09PM +0000, Laurent Pinchart wrote:
> Instead of walking the list of registered SMMU devices at remove time to
> locate the device being removed, set platform driver data at probe time
> to point to the SMMU and retrieve the pointer at remove time.
What does this gain us other than a slight code shrinkage? If we could get
rid of the arm_smmu_devices list, then I'd be more excited by this change!
Will
next prev parent reply other threads:[~2014-02-28 16:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 15:37 [PATCH 0/2] ARM SMMU fixes Laurent Pinchart
[not found] ` <1393601830-4677-1-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2014-02-28 15:37 ` [PATCH 1/2] iommu/arm-smmu: Replace list walk with platform driver data Laurent Pinchart
[not found] ` <1393601830-4677-2-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2014-02-28 16:38 ` Will Deacon [this message]
[not found] ` <20140228163837.GC30996-MRww78TxoiP5vMa5CHWGZ34zcgK1vI+I0E9HWUfgJXw@public.gmane.org>
2014-03-02 17:59 ` Laurent Pinchart
2014-02-28 15:37 ` [PATCH 2/2] iommu/arm-smmu: Return 0 on unmap failure Laurent Pinchart
[not found] ` <1393601830-4677-3-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2014-02-28 16:39 ` Will Deacon
2014-04-02 23:52 ` [PATCH 0/2] ARM SMMU fixes Laurent Pinchart
2014-04-08 13:41 ` Laurent Pinchart
2014-04-08 13:57 ` Marc Zyngier
[not found] ` <53440057.6020703-5wv7dgnIgG8@public.gmane.org>
2014-04-14 16:58 ` Will Deacon
[not found] ` <20140414165858.GI12916-5wv7dgnIgG8@public.gmane.org>
2014-04-15 15:55 ` Laurent Pinchart
2014-04-16 14:22 ` Will Deacon
[not found] ` <20140416142206.GB2005-5wv7dgnIgG8@public.gmane.org>
2014-04-16 14:25 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228163837.GC30996@mudshark.cambridge.arm.com \
--to=will.deacon-5wv7dgnigg8@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).