From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH 1/2] iommu/arm-smmu: Replace list walk with platform driver data Date: Fri, 28 Feb 2014 16:38:37 +0000 Message-ID: <20140228163837.GC30996@mudshark.cambridge.arm.com> References: <1393601830-4677-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1393601830-4677-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1393601830-4677-2-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Laurent Pinchart Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: iommu@lists.linux-foundation.org Hi Laurent, On Fri, Feb 28, 2014 at 03:37:09PM +0000, Laurent Pinchart wrote: > Instead of walking the list of registered SMMU devices at remove time to > locate the device being removed, set platform driver data at probe time > to point to the SMMU and retrieve the pointer at remove time. What does this gain us other than a slight code shrinkage? If we could get rid of the arm_smmu_devices list, then I'd be more excited by this change! Will