Linux IOMMU Development
 help / color / mirror / Atom feed
From: Cho KyongHo <pullip.cho@samsung.com>
To: Grant Grundler <grundler@chromium.org>
Cc: Tomasz Figa <t.figa@samsung.com>,
	Linux ARM Kernel <linux-arm-kernel@lists.infradead.org>,
	Linux DeviceTree <devicetree@vger.kernel.org>,
	Linux IOMMU <iommu@lists.linux-foundation.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Linux Samsung SOC <linux-samsung-soc@vger.kernel.org>,
	Antonios Motakis <a.motakis@virtualopensystems.com>,
	Joerg Roedel <joro@8bytes.org>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Prathyush <prathyush.k@samsung.com>,
	Rahul Sharma <rahul.sharma@samsung.com>,
	Sachin Kamat <sachin.kamat@linaro.org>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Varun Sethi <Varun.Sethi@freescale.com>
Subject: Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions
Date: Thu, 20 Mar 2014 20:55:41 +0900	[thread overview]
Message-ID: <20140320205541.d7ef53fd15d9dcd3cadfd13f@samsung.com> (raw)
In-Reply-To: <CANEJEGtK-XfTef3ko+Yq2RNFXohhuQjgamr-DRBmxR-SNzgkJg@mail.gmail.com>

On Wed, 19 Mar 2014 09:54:39 -0700, Grant Grundler wrote:
> On Wed, Mar 19, 2014 at 6:12 AM, Tomasz Figa <t.figa@samsung.com> wrote:
> ...
> >> Device driver is not only for the scholarship but also for the real use.
> >
> > Huh? I'm not sure what kind of comment is this.
> 
> I'm guessing Cho meant: "This isn't an academic exercise - I have a
> real use case that requires reference counting."

That is what I meant; Sorry for my poor English :-)

> Cho needs to be more specific about his "Some driver needs enabling
> sysmmu" example. Then others would understand why/when the reference
> counting is needed. Ie walk through a real driver that exists today
> that depends on reference counting.
>

One of my recent experience is that a display controller (FIMD) driver
of a SoC manages two different context of power management:
One is turning on and off display screen (LCD) (which is as usual as previous SoCs)
and the other is gating its internal clock including System MMU very
frequently to reduce power consumption.
Because System MMU driver holds its clock ungated while it is enabled,
FIMD driver explicitely disable System MMU.

Yes, well designed FIMD driver must care about balancing of
disabling and enabling System MMU between different contexts.
But the design of some complex driver may be poor in few features due to
agressive development schedule sometimes.

Please let me think about the counting.

Now I also think the system mmu driver does not need to make
an extra effort for some special cases.

Regards,

KyongHo

  reply	other threads:[~2014-03-20 11:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14  5:08 [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions Cho KyongHo
     [not found] ` <20140314140843.ba055f28dd7ed59c46088029-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-03-14 12:59   ` Tomasz Figa
2014-03-18  9:56     ` Cho KyongHo
     [not found]       ` <20140318185605.0380c8dfe6559c06183092e5-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-03-18 15:09         ` Tomasz Figa
     [not found]           ` <532861BE.7020601-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-03-19  1:03             ` Cho KyongHo
     [not found]               ` <20140319100304.5e26fa43ccdfc29178b058e1-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-03-19 13:12                 ` Tomasz Figa
     [not found]                   ` <532997D7.6090608-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-03-19 16:54                     ` Grant Grundler
2014-03-20 11:55                       ` Cho KyongHo [this message]
2014-03-19 17:03                     ` Grant Grundler
     [not found]                       ` <CANEJEGuYz28dGT+264CYtG+Tk6htOq=u-t4PWMtsij32X0vJFA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-19 17:30                         ` Tomasz Figa
     [not found]                           ` <5329D426.9020706-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-03-19 18:37                             ` Grant Grundler
     [not found]                               ` <CANEJEGtCdMmWXwpoky8USLOBw7jAt1bRw8or-mDK7twxAzhWpA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-19 18:51                                 ` Tomasz Figa
     [not found]                                   ` <5329E729.4020201-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-20 12:07                                     ` Cho KyongHo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140320205541.d7ef53fd15d9dcd3cadfd13f@samsung.com \
    --to=pullip.cho@samsung.com \
    --cc=Varun.Sethi@freescale.com \
    --cc=a.motakis@virtualopensystems.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grundler@chromium.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=prathyush.k@samsung.com \
    --cc=rahul.sharma@samsung.com \
    --cc=s.nawrocki@samsung.com \
    --cc=sachin.kamat@linaro.org \
    --cc=t.figa@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox