From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: Laurent Pinchart
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
Cc: Marc Zyngier <Marc.Zyngier-5wv7dgnIgG8@public.gmane.org>,
"iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 0/2] ARM SMMU fixes
Date: Wed, 16 Apr 2014 15:22:06 +0100 [thread overview]
Message-ID: <20140416142206.GB2005@arm.com> (raw)
In-Reply-To: <15544035.e9eK8n7TO4@avalon>
On Tue, Apr 15, 2014 at 04:55:07PM +0100, Laurent Pinchart wrote:
> Hi Will,
Hi Laurent,
> On a different but related topic, I've written an ipmmu-vmsa.c driver for a
> Renesas IOMMU. The IP core has custom registers but uses VMSA-compatible page
> tables. What would you think about sharing the page table management code
> between the two drivers ? The biggest difference between the two
> implementations is that I've hardcoded the long descriptor format, while you
> have reused more system MMU macros that make the arm-smmu driver use 2 or 3
> levels of page tables depending on whether LPAE is disabled or enabled.
Actually, my driver also only supports the long-descriptor format, so the
code should be shareable. Things I support that you might have issues with
are:
- Stage-1 and Stage-2 formats (although long-descriptor only)
- 4k and 64k pages (the latter for arm64 only)
- Contiguous pte hints
Do you have support for section mappings in your driver? That is something
I'd be keen to add for the ARM SMMU, but it really complicates the code.
Will
next prev parent reply other threads:[~2014-04-16 14:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 15:37 [PATCH 0/2] ARM SMMU fixes Laurent Pinchart
[not found] ` <1393601830-4677-1-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2014-02-28 15:37 ` [PATCH 1/2] iommu/arm-smmu: Replace list walk with platform driver data Laurent Pinchart
[not found] ` <1393601830-4677-2-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2014-02-28 16:38 ` Will Deacon
[not found] ` <20140228163837.GC30996-MRww78TxoiP5vMa5CHWGZ34zcgK1vI+I0E9HWUfgJXw@public.gmane.org>
2014-03-02 17:59 ` Laurent Pinchart
2014-02-28 15:37 ` [PATCH 2/2] iommu/arm-smmu: Return 0 on unmap failure Laurent Pinchart
[not found] ` <1393601830-4677-3-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2014-02-28 16:39 ` Will Deacon
2014-04-02 23:52 ` [PATCH 0/2] ARM SMMU fixes Laurent Pinchart
2014-04-08 13:41 ` Laurent Pinchart
2014-04-08 13:57 ` Marc Zyngier
[not found] ` <53440057.6020703-5wv7dgnIgG8@public.gmane.org>
2014-04-14 16:58 ` Will Deacon
[not found] ` <20140414165858.GI12916-5wv7dgnIgG8@public.gmane.org>
2014-04-15 15:55 ` Laurent Pinchart
2014-04-16 14:22 ` Will Deacon [this message]
[not found] ` <20140416142206.GB2005-5wv7dgnIgG8@public.gmane.org>
2014-04-16 14:25 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416142206.GB2005@arm.com \
--to=will.deacon-5wv7dgnigg8@public.gmane.org \
--cc=Marc.Zyngier-5wv7dgnIgG8@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).