From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: Kefeng Wang <wangkefeng.wang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
"guohanjun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org"
<guohanjun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] iommu/arm-smmu: fix incorrect use of S2CR_TYPE_SHIFT
Date: Tue, 22 Apr 2014 11:40:52 +0100 [thread overview]
Message-ID: <20140422104052.GI7484@arm.com> (raw)
In-Reply-To: <5356441E.3040601-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On Tue, Apr 22, 2014 at 11:27:42AM +0100, Kefeng Wang wrote:
> On 04/22 18:00, Will Deacon wrote:
> > On Fri, Apr 18, 2014 at 03:31:17AM +0100, Kefeng Wang wrote:
> >> On 04/18 10:07, Kefeng Wang wrote:
> >>> There is already S2CR_TYPE_TRANS in S2CR_TYPE_TRANS macro,
> ^^^^^^^^^^^^^^^
> >>> so drop the second shift.
> >>
> >> Typo issue, please use following patch.
> >
> > They look the same to me -- which one should I take?
> >
> > Also, since S2CR_TYPE_TRANS is 0x0, this fix isn't critical, so I'll include
> > it in my updates pull for 3.16.
>
> OK, please use second one, thanks.
Ok, thanks.
Will
prev parent reply other threads:[~2014-04-22 10:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 2:07 [PATCH] iommu/arm-smmu: fix incorrect use of S2CR_TYPE_SHIFT Kefeng Wang
[not found] ` <1397786874-11372-1-git-send-email-wangkefeng.wang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-04-18 2:31 ` Kefeng Wang
[not found] ` <53508E75.2080703-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-04-22 10:00 ` Will Deacon
[not found] ` <20140422100015.GA7484-5wv7dgnIgG8@public.gmane.org>
2014-04-22 10:27 ` Kefeng Wang
[not found] ` <5356441E.3040601-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-04-22 10:40 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422104052.GI7484@arm.com \
--to=will.deacon-5wv7dgnigg8@public.gmane.org \
--cc=guohanjun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=wangkefeng.wang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).