iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 03/15] iommu/arm-smmu: fix decimal printf format specifiers prefixed with 0x
@ 2014-08-06  4:42 Hans Wennborg
       [not found] ` <1407300121-32432-1-git-send-email-hans-7z9IcJk4adCsTnJN9+BGXg@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Hans Wennborg @ 2014-08-06  4:42 UTC (permalink / raw)
  To: will.deacon, iommu, linux-kernel; +Cc: Hans Wennborg

The prefix suggests the number should be printed in hex, so use
the %x specifier to do that.

Found by using regex suggested by Joe Perches.

Signed-off-by: Hans Wennborg <hans@hanshq.net>
---
 drivers/iommu/arm-smmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index ca18d6d..d84f983 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -623,7 +623,7 @@ static irqreturn_t arm_smmu_context_fault(int irq, void *dev)
 
 	if (fsr & FSR_IGN)
 		dev_err_ratelimited(smmu->dev,
-				    "Unexpected context fault (fsr 0x%u)\n",
+				    "Unexpected context fault (fsr 0x%x)\n",
 				    fsr);
 
 	fsynr = readl_relaxed(cb_base + ARM_SMMU_CB_FSYNR0);
-- 
2.0.0.526.g5318336

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 03/15] iommu/arm-smmu: fix decimal printf format specifiers prefixed with 0x
       [not found] ` <1407300121-32432-1-git-send-email-hans-7z9IcJk4adCsTnJN9+BGXg@public.gmane.org>
@ 2014-08-06 10:20   ` Will Deacon
  0 siblings, 0 replies; 2+ messages in thread
From: Will Deacon @ 2014-08-06 10:20 UTC (permalink / raw)
  To: Hans Wennborg
  Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org

On Wed, Aug 06, 2014 at 05:42:01AM +0100, Hans Wennborg wrote:
> The prefix suggests the number should be printed in hex, so use
> the %x specifier to do that.
> 
> Found by using regex suggested by Joe Perches.
> 
> Signed-off-by: Hans Wennborg <hans-7z9IcJk4adCsTnJN9+BGXg@public.gmane.org>
> ---
>  drivers/iommu/arm-smmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index ca18d6d..d84f983 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -623,7 +623,7 @@ static irqreturn_t arm_smmu_context_fault(int irq, void *dev)
>  
>  	if (fsr & FSR_IGN)
>  		dev_err_ratelimited(smmu->dev,
> -				    "Unexpected context fault (fsr 0x%u)\n",
> +				    "Unexpected context fault (fsr 0x%x)\n",
>  				    fsr);
>  
>  	fsynr = readl_relaxed(cb_base + ARM_SMMU_CB_FSYNR0);

Thanks, applied.

Will

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-08-06 10:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-06  4:42 [PATCH 03/15] iommu/arm-smmu: fix decimal printf format specifiers prefixed with 0x Hans Wennborg
     [not found] ` <1407300121-32432-1-git-send-email-hans-7z9IcJk4adCsTnJN9+BGXg@public.gmane.org>
2014-08-06 10:20   ` Will Deacon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).