From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
Cc: iommu-cunTk1MwBs98uUxBSJOaYoYkZiVZrdSR2LY78lusg7I@public.gmane.org,
tchalamarla-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
robin.murphy-5wv7dgnIgG8@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/7] iommu/arm-smmu: add support for multi-master iommu groups
Date: Mon, 15 Sep 2014 17:22:57 +0200 [thread overview]
Message-ID: <20140915152257.GX28786@8bytes.org> (raw)
In-Reply-To: <1409849405-17347-3-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
On Thu, Sep 04, 2014 at 05:50:00PM +0100, Will Deacon wrote:
> static struct arm_smmu_master_cfg *
> -find_smmu_master_cfg(struct arm_smmu_device *smmu, struct device *dev)
> +find_smmu_master_cfg(struct device *dev)
> {
> - struct arm_smmu_master *master;
> -
> - if (dev_is_pci(dev))
> - return dev->archdata.iommu;
> -
> - master = find_smmu_master(smmu, dev->of_node);
> - return master ? &master->cfg : NULL;
> + struct iommu_group *group = iommu_group_get(dev);
> + return group ? iommu_group_get_iommudata(group) : NULL;
Using iommu_group_get requires the call-sites to do an iommu_group_put
in the end, but I don't see the call-sites updated.
Joerg
next parent reply other threads:[~2014-09-15 15:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1409849405-17347-1-git-send-email-will.deacon@arm.com>
[not found] ` <1409849405-17347-3-git-send-email-will.deacon@arm.com>
[not found] ` <1409849405-17347-3-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2014-09-15 15:22 ` Joerg Roedel [this message]
[not found] ` <20140915152257.GX28786-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-09-15 18:36 ` [PATCH 2/7] iommu/arm-smmu: add support for multi-master iommu groups Will Deacon
[not found] ` <1409849405-17347-6-git-send-email-will.deacon@arm.com>
[not found] ` <1409849405-17347-6-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2014-12-01 20:39 ` [PATCH 5/7] iommu/arm-smmu: don't bother truncating the s1 output size to VA_BITS Andreas Schwab
[not found] ` <87mw77cdft.fsf@igel.home>
[not found] ` <87mw77cdft.fsf-hBGjKatGTSWzQB+pC5nmwQ@public.gmane.org>
2014-12-02 9:26 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915152257.GX28786@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=iommu-cunTk1MwBs98uUxBSJOaYoYkZiVZrdSR2LY78lusg7I@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
--cc=tchalamarla-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox