From: Alex Williamson <alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
mstowe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: [PATCH 0/2] iommu: Fix regression in IOMMU grouping
Date: Fri, 19 Sep 2014 10:03:00 -0600 [thread overview]
Message-ID: <20140919154944.14485.743.stgit@gimli.home> (raw)
We've had surprisingly little fallout from the DMA alias changes, but
unfortunately one regression has popped up. We have an AMD system
that seems to use the SATA controller to master transactions for the
legacy IDE controller and they are different slots on the root complex.
The IVRS reports 00:11.0 (SATA) as an alias from 00:14.1 (IDE), which
doesn't work with the new, converged PCI IOMMU grouping code, where
we've made a simplifying assumption that aliases will be to the same
slot.
To fix this, we need to rip out that assumption and write the alias
search code that I was unable to come up with previously. I think
this can now do the chaining of aliases, which I referenced in the
removed comments. Any sort of multi-level aliases are exceptionally
unlikely, but I think this code can now handle whatever firmware and
alias quirks can throw at it.
I know this is late for 3.17, but this is a regression from the prior
code. If reviews and testing can give us the confidence to put it in
for 3.17, that would be my preference. I've also marked it for stable
in case we want to loop back through that way. Thanks,
Alex
---
Alex Williamson (2):
iommu/amd: Split init_iommu_group() from iommu_init_device()
iommu: Rework iommu_group_get_for_pci_dev()
drivers/iommu/amd_iommu.c | 27 ++++---
drivers/iommu/iommu.c | 163 +++++++++++++++++++++++++++------------------
2 files changed, 109 insertions(+), 81 deletions(-)
next reply other threads:[~2014-09-19 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 16:03 Alex Williamson [this message]
[not found] ` <20140919154944.14485.743.stgit-GCcqpEzw8uZBDLzU/O5InQ@public.gmane.org>
2014-09-19 16:03 ` [PATCH 1/2] iommu: Rework iommu_group_get_for_pci_dev() Alex Williamson
2014-09-19 16:03 ` [PATCH 2/2] iommu/amd: Split init_iommu_group() from iommu_init_device() Alex Williamson
2014-09-25 14:40 ` [PATCH 0/2] iommu: Fix regression in IOMMU grouping Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140919154944.14485.743.stgit@gimli.home \
--to=alex.williamson-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mstowe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).