From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Tomeu Vizoso <tomeu-XCtybt49RKsYaV1qd6yewg@public.gmane.org>
Cc: "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Mike Turquette
<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Peter De Schrijver
<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Prashant Gaikwad
<pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v3 01/12] clk: tegra: Implement memory-controller clock
Date: Thu, 30 Oct 2014 15:57:46 +0100 [thread overview]
Message-ID: <20141030145744.GE20072@ulmo.nvidia.com> (raw)
In-Reply-To: <CAAObsKB0ozbOy8ZzgbEyf-SrqF5jpfHUXCJdAMiqgS78DAyaVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 633 bytes --]
On Mon, Oct 20, 2014 at 01:02:45PM +0200, Tomeu Vizoso wrote:
> On 13 October 2014 12:33, Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
[...]
> > +struct clk *tegra_clk_register_mc(const char *name, const char *parent_name,
> > + void __iomem *reg, spinlock_t *lock)
> > +{
> > + return clk_register_divider_table(NULL, "mc", "emc_mux", 0, reg,
>
> Should take name and parent_name from the passed args?
>
> With that change:
>
> Reviewed-By: Tomeu Vizoso <tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
Good catch.
Thanks,
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-10-30 14:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 10:33 [PATCH v3 01/12] clk: tegra: Implement memory-controller clock Thierry Reding
[not found] ` <1413196434-5292-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-13 10:33 ` [PATCH 02/12] amba: Add Kconfig file Thierry Reding
2014-10-13 10:33 ` [PATCH v4 03/12] ARM: tegra: Move AHB Kconfig to drivers/amba Thierry Reding
2014-10-13 10:33 ` [PATCH 04/12] of: Add NVIDIA Tegra memory controller binding Thierry Reding
2014-10-13 10:33 ` [PATCH v4 05/12] memory: Add NVIDIA Tegra memory controller support Thierry Reding
[not found] ` <1413196434-5292-5-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-15 22:05 ` Olof Johansson
[not found] ` <CAOesGMjMcqa_wE7rfA42QyvF7yxAkgjEN+-0UVMuErnjHr4zkA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-30 15:32 ` Thierry Reding
2014-10-15 22:09 ` Olof Johansson
[not found] ` <CAOesGMgDE_PZHrrEhntnce2AMsdtAb9+i5XuxP-Q7j--432zpw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-30 15:08 ` Thierry Reding
[not found] ` <20141030150839.GG20072-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2014-10-31 13:27 ` Thierry Reding
[not found] ` <20141031132740.GA9371-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2014-11-01 5:38 ` Alexandre Courbot
[not found] ` <CAAVeFuKgMAF4LML5G=2k00No4AKDj7MTHB6ByXEvPzaSsAPUXg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-03 8:22 ` Thierry Reding
[not found] ` <20141103082201.GC21002-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2014-11-03 8:40 ` Alexandre Courbot
2014-10-30 10:03 ` Alexandre Courbot
[not found] ` <54520CFE.9060907-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-10-30 10:18 ` Terje Bergström
[not found] ` <5452107D.8080207-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-10-30 10:22 ` Alexandre Courbot
[not found] ` <54521181.8080005-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-10-30 11:04 ` Terje Bergström
[not found] ` <54521B22.6070708-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-10-30 13:35 ` Alexandre Courbot
[not found] ` <54523E8B.7000900-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-10-30 13:47 ` Terje Bergström
[not found] ` <5452418F.8080005-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-10-30 14:56 ` Thierry Reding
2014-10-13 10:33 ` [PATCH 06/12] ARM: tegra: Add memory controller support for Tegra20 Thierry Reding
[not found] ` <1413196434-5292-6-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-17 17:43 ` David Riley
[not found] ` <CAASgrz3Z2vW0L+u5kju9bAh-R4PnreMnhoGaKY_UwSTGFcBshA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-30 14:45 ` Thierry Reding
2014-10-13 10:33 ` [PATCH 07/12] ARM: tegra: Add memory controller support for Tegra30 Thierry Reding
2014-10-13 10:33 ` [PATCH 08/12] ARM: tegra: Add memory controller support for Tegra114 Thierry Reding
2014-10-13 10:33 ` [PATCH 09/12] ARM: tegra: Add memory controller support for Tegra124 Thierry Reding
2014-10-13 10:33 ` [PATCH 10/12] ARM: tegra: Enable IOMMU for display controllers on Tegra30 Thierry Reding
2014-10-13 10:33 ` [PATCH 11/12] ARM: tegra: Enable IOMMU for display controllers on Tegra114 Thierry Reding
2014-10-13 10:33 ` [PATCH 12/12] ARM: tegra: Enable IOMMU for display controllers on Tegra124 Thierry Reding
2014-10-20 11:02 ` [PATCH v3 01/12] clk: tegra: Implement memory-controller clock Tomeu Vizoso
[not found] ` <CAAObsKB0ozbOy8ZzgbEyf-SrqF5jpfHUXCJdAMiqgS78DAyaVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-30 14:57 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030145744.GE20072@ulmo.nvidia.com \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=tomeu-XCtybt49RKsYaV1qd6yewg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).