Re: [PATCH v4 05/12] memory: Add NVIDIA Tegra memory controller support

[Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2419 bytes --]

On Wed, Oct 15, 2014 at 03:09:30PM -0700, Olof Johansson wrote:
> Hi,
> 
> Oh, a few more comments:
> 
> On Mon, Oct 13, 2014 at 3:33 AM, Thierry Reding
> <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> 
> > diff --git a/drivers/memory/Makefile b/drivers/memory/Makefile
> > index c32d31981be3..1c932e7e7b8d 100644
> > --- a/drivers/memory/Makefile
> > +++ b/drivers/memory/Makefile
> > @@ -12,4 +12,5 @@ obj-$(CONFIG_FSL_CORENET_CF)  += fsl-corenet-cf.o
> >  obj-$(CONFIG_FSL_IFC)          += fsl_ifc.o
> >  obj-$(CONFIG_MVEBU_DEVBUS)     += mvebu-devbus.o
> >  obj-$(CONFIG_TEGRA20_MC)       += tegra20-mc.o
> > -obj-$(CONFIG_TEGRA30_MC)       += tegra30-mc.o
> > +
> > +obj-$(CONFIG_ARCH_TEGRA)       += tegra/
> > diff --git a/drivers/memory/tegra/Makefile b/drivers/memory/tegra/Makefile
> > new file mode 100644
> > index 000000000000..51b9e8fcde1b
> > --- /dev/null
> > +++ b/drivers/memory/tegra/Makefile
> > @@ -0,0 +1,5 @@
> > +obj-y                                   = tegra-mc.o
> > +obj-$(CONFIG_ARCH_TEGRA_3x_SOC)                += tegra30-mc.o
> > +obj-$(CONFIG_ARCH_TEGRA_114_SOC)       += tegra114-mc.o
> > +obj-$(CONFIG_ARCH_TEGRA_124_SOC)       += tegra124-mc.o
> > +obj-$(CONFIG_ARCH_TEGRA_132_SOC)       += tegra124-mc.o
> 
> You'll need a Kconfig and not just a makefile -- there are definitely
> dependencies on this driver (IOMMU in particular).

This is handled within the tegra-mc driver by only setting up the IOMMU
when TEGRA_IOMMU_SMMU is enabled. That config option remains in place.

> Also, the problem of having a global enable bit that is only under
> control of TrustZone FW is a big problem -- if the bit is not set, the
> driver will not work (and the machine will crash).
> 
> I think you'll need to come up with a way to detect that in the
> driver. I don't have a good idea of how it can be done though.

I don't think I ever got back to you on this. We discussed this
internally and it seems like there's no way to detect this properly, so
the best suggestion so far was to make it a requirement on the secure
firmware to enable IOMMU or not. Since there's no way for the kernel to
detect whether IOMMU was enabled or not, I think the firmware would
equally have to adjust the SMMU's device tree node's status property
appropriately.

Stephen, does that accurately reflect what we had discussed?

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]