From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Oded Gabbay <oded.gabbay-5C7GfCeVMHo@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/1] iommu/amd: Use delayed mmu release notifier
Date: Thu, 6 Nov 2014 14:33:54 +0100 [thread overview]
Message-ID: <20141106133354.GP10744@8bytes.org> (raw)
In-Reply-To: <54418D7F.3050304-5C7GfCeVMHo@public.gmane.org>
On Sat, Oct 18, 2014 at 12:43:27AM +0300, Oded Gabbay wrote:
> 3. Later, amdkfd's mmu notifier callback (kfd_process_notifier_release()) gets
> called and releases more things that are related to the process.
> In that function, amd_iommu_unbind_pasid() is explicitly called.
Can't you just register a delayed funtion in
kfd_process_notifier_release() and call amd_iommu_unbind_pasid() from
there? I really hate to make that part of the IOMMUv2 driver API,
especially since it is going to be turned into a generic IOMMU-API
extension.
And especially since all these hacks could be avoided if the KFD driver
would just turn down everything on closing the file descriptor.
Joerg
next prev parent reply other threads:[~2014-11-06 13:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 21:43 [PATCH 1/1] iommu/amd: Use delayed mmu release notifier Oded Gabbay
2014-10-25 19:16 ` Oded Gabbay
2014-11-03 11:51 ` Oded Gabbay
[not found] ` <54418D7F.3050304-5C7GfCeVMHo@public.gmane.org>
2014-11-06 13:33 ` Joerg Roedel [this message]
2014-11-06 13:48 ` Oded Gabbay
[not found] ` <545B7C43.4020106-5C7GfCeVMHo@public.gmane.org>
2014-11-06 22:51 ` Joerg Roedel
2014-11-07 20:22 ` Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106133354.GP10744@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oded.gabbay-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox