Linux IOMMU Development
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: Laurent Pinchart
	<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
Cc: "jroedel-l3A5Bk7waGM@public.gmane.org"
	<jroedel-l3A5Bk7waGM@public.gmane.org>,
	"arnd-r2nGTMty4D4@public.gmane.org"
	<arnd-r2nGTMty4D4@public.gmane.org>,
	"iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
	<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	"thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org"
	<Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	"dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org"
	<dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 1/2] iommu: move pgsize_bitmap from struct iommu_ops to struct iommu_domain
Date: Fri, 6 Mar 2015 12:34:53 +0000	[thread overview]
Message-ID: <20150306123453.GK22377@arm.com> (raw)
In-Reply-To: <1973968.aLfySGl5av@avalon>

On Fri, Mar 06, 2015 at 11:57:58AM +0000, Laurent Pinchart wrote:
> On Friday 06 March 2015 11:34:47 Will Deacon wrote:
> > @@ -108,8 +109,6 @@ enum iommu_attr {
> >   * @domain_get_attr: Query domain attributes
> >   * @domain_set_attr: Change domain attributes
> >   * @of_xlate: add OF master IDs to iommu grouping
> > - * @pgsize_bitmap: bitmap of supported page sizes
> > - * @priv: per-instance data private to the iommu driver
> >   */
> >  struct iommu_ops {
> >  	bool (*capable)(enum iommu_cap);
> > @@ -144,9 +143,6 @@ struct iommu_ops {
> >  #ifdef CONFIG_OF_IOMMU
> >  	int (*of_xlate)(struct device *dev, struct of_phandle_args *args);
> >  #endif
> > -
> > -	unsigned long pgsize_bitmap;
> > -	void *priv;
> 
> The commit message doesn't mention the removal of the priv field.

Yup, that's sloppy. I'll move it into a separate patch.

Will

  reply	other threads:[~2015-03-06 12:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-06 11:34 [PATCH 0/2] Kill off pgsize_bitmap field from struct iommu_ops Will Deacon
     [not found] ` <1425641688-26438-1-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2015-03-06 11:34   ` [PATCH 1/2] iommu: move pgsize_bitmap from struct iommu_ops to struct iommu_domain Will Deacon
     [not found]     ` <1425641688-26438-2-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2015-03-06 11:56       ` Laurent Pinchart
2015-03-06 11:59         ` Will Deacon
2015-03-06 11:57       ` Laurent Pinchart
2015-03-06 12:34         ` Will Deacon [this message]
2015-03-06 12:24       ` Marek Szyprowski
2015-03-07 16:17       ` Daniel Kurtz
2015-03-11  8:38       ` Thierry Reding
2015-03-06 11:34   ` [PATCH 2/2] iommu: of: enforce const-ness of struct iommu_ops Will Deacon
     [not found]     ` <1425641688-26438-3-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2015-03-11  8:43       ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150306123453.GK22377@arm.com \
    --to=will.deacon-5wv7dgnigg8@public.gmane.org \
    --cc=Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=jroedel-l3A5Bk7waGM@public.gmane.org \
    --cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox