From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [v4 2/8] iommu, x86: Define new irte structure for VT-d Posted-Interrupts Date: Mon, 23 Mar 2015 12:57:54 +0100 Message-ID: <20150323115754.GN4441@8bytes.org> References: <1422864424-19411-1-git-send-email-feng.wu@intel.com> <1422864424-19411-3-git-send-email-feng.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1422864424-19411-3-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Feng Wu Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, jiang.liu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: iommu@lists.linux-foundation.org Hi Feng, On Mon, Feb 02, 2015 at 04:06:58PM +0800, Feng Wu wrote: > Add a new irte_pi structure for VT-d Posted-Interrupts. > > Signed-off-by: Feng Wu > Reviewed-by: Jiang Liu > Acked-by: David Woodhouse > --- > include/linux/dmar.h | 32 ++++++++++++++++++++++++++++++++ > 1 files changed, 32 insertions(+), 0 deletions(-) > > diff --git a/include/linux/dmar.h b/include/linux/dmar.h > index 8473756..c7f9cda 100644 > --- a/include/linux/dmar.h > +++ b/include/linux/dmar.h > @@ -212,6 +212,38 @@ struct irte { > }; > }; > > +struct irte_pi { I think it is better to put this as a union into struct irte. It saves memory and unnecessary casting in later patches. Joerg