From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cho KyongHo Subject: Re: [PATCH v6 05/25] iommu: exynos: don't read version register on every tlb operation Date: Sun, 10 May 2015 21:59:50 +0900 Message-ID: <20150510215950.c4d5dacc81d17c4b470cefb5@samsung.com> References: <1430727380-10912-1-git-send-email-m.szyprowski@samsung.com> <1430727380-10912-6-git-send-email-m.szyprowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <1430727380-10912-6-git-send-email-m.szyprowski@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Marek Szyprowski Cc: iommu@lists.linux-foundation.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-mm-sig@lists.linaro.org, Arnd Bergmann , Shaik Ameer Basha , Joerg Roedel , Thierry Reding , Olof Johansson , Laurent Pinchart , Rob Herring , Will Deacon , David Wodhouse , Inki Dae , Kukjin Kim , Tomasz Figa , Kyungmin Park , Joonyoung Shim , Seung-Woo Kim , Javier Martinez Canillas List-Id: iommu@lists.linux-foundation.org On Mon, 04 May 2015 10:16:00 +0200 Marek Szyprowski wrote: > This patch removes reading of REG_MMU_VERSION register on every tlb > operation and caches SYSMMU version in driver's internal data. > > Signed-off-by: Marek Szyprowski > --- > drivers/iommu/exynos-iommu.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > index 3e898504a7c4..3861485f0689 100644 > --- a/drivers/iommu/exynos-iommu.c > +++ b/drivers/iommu/exynos-iommu.c > @@ -213,6 +213,7 @@ struct sysmmu_drvdata { > spinlock_t lock; > struct iommu_domain *domain; > phys_addr_t pgtable; > + int version; Why don't you define its type as unsigned int or u32? Regards, KyongHo