From: Joerg Roedel <joro@8bytes.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: iommu@lists.linux-foundation.org,
linux-samsung-soc@vger.kernel.org,
Shaik Ameer Basha <shaik.ameer@samsung.com>,
Cho KyongHo <pullip.cho@samsung.com>,
Inki Dae <inki.dae@samsung.com>,
Javier Martinez Canillas <javier@dowhile0.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>
Subject: Re: [PATCH] iommu: Ignore -ENODEV errors from add_device call-back returning -ENODEV
Date: Mon, 29 Jun 2015 15:43:19 +0200 [thread overview]
Message-ID: <20150629134319.GJ18569@8bytes.org> (raw)
In-Reply-To: <55910797.7090709@samsung.com>
On Mon, Jun 29, 2015 at 10:53:43AM +0200, Marek Szyprowski wrote:
> On 2015-06-29 10:35, Joerg Roedel wrote:
> >The -ENODEV error just means that the device is not
> >translated by an IOMMU. We shouldn't bail out of iommu
> >driver initialization when that happens, as this is a common
> >scenario on ARM.
> >
> >No returning -ENODEV in the drivers would be a bad idea, as
> >the IOMMU core would have no indication whether a device is
> >translated or not. This information is not used at the
> >moment, but will probably be in the future.
> >
> >Signed-off-by: Joerg Roedel <jroedel@suse.de>
>
> Works fine!
>
> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Thanks for testing! The patch is queued now.
prev parent reply other threads:[~2015-06-29 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 13:10 [PATCH] iommu/exynos: Skip unsupported devices instead of returning -ENODEV Marek Szyprowski
2015-06-29 8:35 ` [PATCH] iommu: Ignore -ENODEV errors from add_device call-back " Joerg Roedel
[not found] ` <20150629083534.GG18569-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-06-29 8:53 ` Marek Szyprowski
2015-06-29 13:43 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150629134319.GJ18569@8bytes.org \
--to=joro@8bytes.org \
--cc=inki.dae@samsung.com \
--cc=iommu@lists.linux-foundation.org \
--cc=javier@dowhile0.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pullip.cho@samsung.com \
--cc=shaik.ameer@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox