Linux IOMMU Development
 help / color / mirror / Atom feed
From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: David Kiarie <davidkiarie4-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: valentine.sinitsyn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	jankiskza-S0/GAf8tV78@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: IVDB DTE_ALL Settings
Date: Tue, 4 Aug 2015 18:56:19 +0200	[thread overview]
Message-ID: <20150804165619.GP14980@8bytes.org> (raw)
In-Reply-To: <20150804025745.GA4128-FBVcP3zgNXf1IFe7KZLm3A@public.gmane.org>

Hi David,

On Tue, Aug 04, 2015 at 05:57:45AM +0300, David Kiarie wrote:
> Basically, the iommu->last/first_device fields are initialized in
> another state of the driver much later in the code(during PCI
> initialization); the values iommu->first/last_device are used before
> initialization which breaks the logic of this code.

You are right, this is probably broken for some time, on the other side
it doesn't matter for now as I've never seen an IVRS table with an
IVHD_ALL field. I'll do a patch to fix this, thanks for the report.



	Joerg

  parent reply	other threads:[~2015-08-04 16:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-04  2:57 IVDB DTE_ALL Settings David Kiarie
     [not found] ` <20150804025745.GA4128-FBVcP3zgNXf1IFe7KZLm3A@public.gmane.org>
2015-08-04 16:56   ` Joerg Roedel [this message]
     [not found]     ` <20150804165619.GP14980-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-08-04 17:05       ` Valentine Sinitsyn
     [not found]         ` <55C0F0E9.6030902-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-08-05  9:48           ` Joerg Roedel
     [not found]             ` <20150805094836.GR14980-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-08-05  9:53               ` Valentine Sinitsyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150804165619.GP14980@8bytes.org \
    --to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
    --cc=davidkiarie4-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=jankiskza-S0/GAf8tV78@public.gmane.org \
    --cc=valentine.sinitsyn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox