From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: IVDB DTE_ALL Settings Date: Wed, 5 Aug 2015 11:48:36 +0200 Message-ID: <20150805094836.GR14980@8bytes.org> References: <20150804025745.GA4128@debian.debian> <20150804165619.GP14980@8bytes.org> <55C0F0E9.6030902@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <55C0F0E9.6030902-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Valentine Sinitsyn Cc: David Kiarie , jankiskza-S0/GAf8tV78@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Tue, Aug 04, 2015 at 10:05:45PM +0500, Valentine Sinitsyn wrote: > Not directly related to the issue David discovered, but as we > discuss IVRS handling: the specification says that ACPI tables data > overrides what's in hardware registers (Sect. 5). To the best of my > understanding, this means e.g. I should take HATS value not from EFR > but from IVHD Type 10 block. However, amd_iommu driver code checks > for features directly - for what reason? I'm not suggesting this is > a bug, but rather asking your opinion here. In my experience the hardware is more trustable than the ACPI table. We had several issues with broken BIOSes that screw up the IVRS ACPI table, so my trust in the values there is limited. Joerg