From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH V3] iommu/arm-smmu-v2: ThunderX mis-extends 64bit registers Date: Tue, 18 Aug 2015 13:44:48 +0100 Message-ID: <20150818124448.GA13507@arm.com> References: <1439853235-12162-1-git-send-email-tchalamarla@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1439853235-12162-1-git-send-email-tchalamarla-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "tchalamarla-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org" Cc: "linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org" , "ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org" , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "robert.richter-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: iommu@lists.linux-foundation.org Hi Tirumalesh, On Tue, Aug 18, 2015 at 12:13:55AM +0100, tchalamarla-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org wrote: > From: Tirumalesh Chalamarla > > The SMMU architecture defines two different behaviors when 64-bit > registers are written with 32-bit writes. The first behavior causes > zero extension into the upper 32-bits. The second behavior splits a > 64-bit register into "normal" 32-bit register pairs. > > On some buggy implementations, registers incorrectly zero extended > when they should instead behave as normal 32-bit register pairs. > > Signed-off-by: Tirumalesh Chalamarla > > Changes from V2: > - removed unused definitions > > Changes from V1: > - Introduced smmu_writeq > --- > drivers/iommu/arm-smmu.c | 57 +++++++++++++++++++++++++----------------------- > 1 file changed, 30 insertions(+), 27 deletions(-) I'm happy with this, but it doesn't apply against mainline or my tree. Please can you rebase it onto something more recent, preferably my iommu/devel branch? Thanks, Will