From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 38/39] iommu/amd: drop null test before destroy functions Date: Tue, 29 Sep 2015 15:41:19 +0200 Message-ID: <20150929134119.GB7572@8bytes.org> References: <1442146532-9100-1-git-send-email-Julia.Lawall@lip6.fr> <1442146532-9100-39-git-send-email-Julia.Lawall@lip6.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1442146532-9100-39-git-send-email-Julia.Lawall@lip6.fr> Sender: kernel-janitors-owner@vger.kernel.org To: Julia Lawall Cc: sergey.senozhatsky@gmail.com, kernel-janitors@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org List-Id: iommu@lists.linux-foundation.org On Sun, Sep 13, 2015 at 02:15:31PM +0200, Julia Lawall wrote: > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ expression x; @@ > -if (x != NULL) { > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); > x = NULL; > -} > // > > Signed-off-by: Julia Lawall > > --- > drivers/iommu/amd_iommu_init.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) Applied, thanks.