From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 1/2] iommu/vt-d: break the for loop if an empty ir_ioapic entry found Date: Tue, 29 Sep 2015 15:50:34 +0200 Message-ID: <20150929135033.GC7572@8bytes.org> References: <1443511569-9187-1-git-send-email-bhe@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1443511569-9187-1-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Baoquan He Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Tue, Sep 29, 2015 at 03:26:08PM +0800, Baoquan He wrote: > No need to continue the loop after it has been found. > > Signed-off-by: Baoquan He > --- > drivers/iommu/intel_irq_remapping.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c > index 9ec4e0d..37b93f5 100644 > --- a/drivers/iommu/intel_irq_remapping.c > +++ b/drivers/iommu/intel_irq_remapping.c > @@ -841,8 +841,10 @@ static int ir_parse_one_ioapic_scope(struct acpi_dmar_device_scope *scope, > if (ir_ioapic[count].iommu == iommu && > ir_ioapic[count].id == scope->enumeration_id) > return 0; > - else if (ir_ioapic[count].iommu == NULL && free == -1) > + else if (ir_ioapic[count].iommu == NULL && free == -1) { > free = count; > + break; > + } > } The purpose of the loop is also to avoid duplicate entries, so we need to search it till the end, no? Joerg