From mboxrd@z Thu Jan 1 00:00:00 1970 From: "gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org" Subject: Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT Date: Tue, 6 Oct 2015 06:12:40 +0100 Message-ID: <20151006051240.GA23487@kroah.com> References: <1444042224.4674.149.camel@intel.com> <1444066723.93285.146.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1444066723.93285.146.camel@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Sudeep Dutt Cc: "Woodhouse, David" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Dixit, Ashutosh" , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "Rao, Nikhil" List-Id: iommu@lists.linux-foundation.org On Mon, Oct 05, 2015 at 10:38:43AM -0700, Sudeep Dutt wrote: > On Mon, 2015-10-05 at 03:50 -0700, Woodhouse, David wrote: > > On Tue, 2015-09-29 at 18:09 -0700, Ashutosh Dixit wrote: > > > From: Sudeep Dutt > > > > > > iova is a library which can be built without IOMMU_SUPPORT > > > > > > Signed-off-by: Sudeep Dutt > > > > The first three of these patches are in 4.3-rc4 already. Apologies for > > the delay in pushing them out. > > > > This one looks sane enough too, but perhaps in that case we should move > > the code *out* of drivers/iommu/ and into lib/iova/ ? > > > > Yes, moving the code into lib/iova is the correct long term solution. I > have sent Greg a patch which reverts this commit since it is no longer > required and will create a merge conflict for him unnecessarily as well > with 4.3-rc4. I can handle merge issues, that's trivial. Reverting the patch shoulnd't really be needed, right? Let me see what happens when I merge to see if your patch is necessary...