From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH v2 1/2] IOMMU: arm-smmu-v3: Fix broken STE.VALID check in Broadcom Vulcan Date: Mon, 21 Dec 2015 09:55:01 +0000 Message-ID: <20151221095500.GB23092@arm.com> References: <1450346376-30920-1-git-send-email-pmallapp@broadcom.com> <20151217114216.GB11456@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Prem (Premachandra) Mallappa" Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , Jayachandran Chandrashekaran Nair , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: iommu@lists.linux-foundation.org On Sat, Dec 19, 2015 at 04:47:30AM +0000, Prem (Premachandra) Mallappa wrote: > Hi Will, Hello Prem, > > > > Is this workaround only needed for bypass STEs? If not, we have a problem > > when we install a stage-1 entry, because we'll clear the EATS bits as it stands. > > > > Yes, this _was_ needed only in Bypass STEs, AFAIK. > However, the h/w fixes that were committed recently has this worked out. > I have tested and confirmed this patch is no longer necessary. We'll drop > this series as STE.VALID is not broken anymore :). Hey, that's an early Christmas present! :) Will