iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
Cc: David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	dri-devel
	<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"open list:IOMMU DRIVERS"
	<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	Shunqian Zheng <zhengsq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	Mark Yao <mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Subject: Re: [PATCH v4 0/8] iommu/rockchip: Fix bugs and enable on ARM64
Date: Tue, 21 Jun 2016 15:18:49 +0200	[thread overview]
Message-ID: <2015742.xhx642kbrC@diego> (raw)
In-Reply-To: <20160621125435.GE11432-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>

Am Dienstag, 21. Juni 2016, 14:54:35 schrieb Joerg Roedel:
> Hi Tomasz,
> 
> On Tue, Jun 21, 2016 at 09:42:16PM +0900, Tomasz Figa wrote:
> > In simple words, DRM patches depend on IOMMU patches.
> > 
> > More precisely: The IOMMU patches alone are supposed to not break
> > anything. Same goes for the first DRM patch (7/8). Only second DRM
> > patch (8/8) depends on changes introduced by its predecessors.
> 
> The first DRM patch is 6/7, so it is 7/8 with the iommu dependency,
> right? Anyway, I think the best is I take the iommu patches when Heiko
> is ok with them and then the DRM tree can merge that branch in to apply
> the DRM patches.
> 
> But first Heiko should have a look at the patches.

I think from all his previous work on the rockchip iommus Tomasz is a lot more 
qualified to judge them - which I guess he did when picking up the ones from 
Rockchip devs :-) .

>From a style-side, please don't carry the Reviewed-on gerrit tags over to 
mainline patches (patches 1 and 2).

Other than that, I didn't see anything jump out and it looks all pretty nice.


Heiko

  parent reply	other threads:[~2016-06-21 13:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-21  4:34 [PATCH v4 0/8] iommu/rockchip: Fix bugs and enable on ARM64 Tomasz Figa
     [not found] ` <1466483681-36110-1-git-send-email-tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-06-21  4:34   ` [PATCH v4 1/8] iommu/rockchip: Fix devm_{request,free}_irq parameter Tomasz Figa
2016-06-21  4:34   ` [PATCH v4 2/8] iommu/rockchip: Add map_sg callback for rk_iommu_ops Tomasz Figa
2016-06-21  4:34   ` [PATCH v4 3/8] iommu/rockchip: Fix allocation of bases array in driver probe Tomasz Figa
     [not found]     ` <1466483681-36110-4-git-send-email-tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-06-21 17:19       ` Doug Anderson
2016-06-21  4:34   ` [PATCH v4 4/8] iommu/rockchip: Use DMA API to manage coherency Tomasz Figa
2016-06-21  4:34   ` [PATCH v4 5/8] iommu/rockchip: Prepare to support generic DMA mapping Tomasz Figa
2016-06-21  4:34   ` [PATCH v4 6/8] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain Tomasz Figa
2016-06-21  4:34   ` [PATCH v4 7/8] drm/rockchip: Use common IOMMU API to attach devices Tomasz Figa
2016-06-21  4:34   ` [PATCH v4 8/8] iommu/rockchip: Enable Rockchip IOMMU on ARM64 Tomasz Figa
2016-06-21  9:17   ` [PATCH v4 0/8] iommu/rockchip: Fix bugs and enable " Joerg Roedel
2016-06-21 12:42     ` Tomasz Figa
2016-06-21 12:54       ` Joerg Roedel
     [not found]         ` <20160621125435.GE11432-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2016-06-21 13:18           ` Heiko Stübner [this message]
2016-06-21 13:52             ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2015742.xhx642kbrC@diego \
    --to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
    --cc=airlied-cv59FeDIM0c@public.gmane.org \
    --cc=djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=zhengsq-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).