From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Suravee Suthikulpanit
<Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
Cc: peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
acme-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org
Subject: Re: [PATCH v2 2/6] perf/amd/iommu: Modify functions to query max banks and counters
Date: Thu, 7 Jan 2016 13:34:12 +0100 [thread overview]
Message-ID: <20160107123411.GH19149@8bytes.org> (raw)
In-Reply-To: <1451672020-2150-3-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
On Fri, Jan 01, 2016 at 12:13:36PM -0600, Suravee Suthikulpanit wrote:
> Currently, amd_iommu_pc_get_max_[banks|counters]() require devid,
> which should not be the case. Also, these don't properly support
> multi-IOMMU system.
>
> Current and future AMD systems with IOMMU that support perf counter
> would likely contain homogeneous IOMMUs where multiple IOMMUs are
> availalbe. So, this patch modifies these function to iterate all IOMMU
> to check the max banks and counters reported by the hardware.
>
> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
> ---
> arch/x86/kernel/cpu/perf_event_amd_iommu.c | 17 +++++++----------
> drivers/iommu/amd_iommu_init.c | 20 ++++++++++++--------
> include/linux/perf/perf_event_amd_iommu.h | 7 ++-----
> 3 files changed, 21 insertions(+), 23 deletions(-)
Reviewed-by: Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>
This looks like the fix for the CZ issue, right? If true, it is
probably v4.5 material.
next prev parent reply other threads:[~2016-01-07 12:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-01 18:13 [PATCH v2 0/6] perf/amd/iommu: Enable multi-IOMMU support Suravee Suthikulpanit
[not found] ` <1451672020-2150-1-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2016-01-01 18:13 ` [PATCH v2 1/6] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header Suravee Suthikulpanit
[not found] ` <1451672020-2150-2-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2016-01-07 12:32 ` Joerg Roedel
2016-01-01 18:13 ` [PATCH v2 2/6] perf/amd/iommu: Modify functions to query max banks and counters Suravee Suthikulpanit
[not found] ` <1451672020-2150-3-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2016-01-07 12:34 ` Joerg Roedel [this message]
[not found] ` <20160107123411.GH19149-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2016-01-07 15:28 ` Suravee Suthikulpanit
2016-01-01 18:13 ` [PATCH v2 4/6] perf/amd/iommu: Introduce data structure for tracking prev count Suravee Suthikulpanit
[not found] ` <1451672020-2150-5-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2016-01-07 12:27 ` Joerg Roedel
2016-01-01 18:13 ` [PATCH v2 5/6] perf/amd/iommu: Introduce get_iommu_bnk_cnt_evt_idx Suravee Suthikulpanit
2016-01-01 18:13 ` [PATCH v2 6/6] perf/amd/iommu: Enable support for multiple IOMMUs Suravee Suthikulpanit
2016-01-01 18:13 ` [PATCH v2 3/6] iommu/amd: Introduce amd_iommu_get_num_iommus() Suravee Suthikulpanit
2016-01-07 12:15 ` Joerg Roedel
[not found] ` <20160107121550.GE19149-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2016-02-09 22:09 ` Suravee Suthikulpanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160107123411.GH19149@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org \
--cc=acme-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).