From: Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>
To: Jay Cornwall <jay-gJmSnxjMpeIFV7jr3Ov9Ew@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] iommu/amd: Apply workaround for ATS write permission check
Date: Thu, 25 Feb 2016 16:07:27 +0100 [thread overview]
Message-ID: <20160225150727.GD2280@suse.de> (raw)
In-Reply-To: <1455140881-17041-1-git-send-email-jay-gJmSnxjMpeIFV7jr3Ov9Ew@public.gmane.org>
On Wed, Feb 10, 2016 at 03:48:01PM -0600, Jay Cornwall wrote:
> The AMD Family 15h Models 30h-3Fh (Kaveri) BIOS and Kernel Developer's
> Guide omitted part of the BIOS IOMMU L2 register setup specification.
> Without this setup the IOMMU L2 does not fully respect write permissions
> when handling an ATS translation request.
>
> The IOMMU L2 will set PTE dirty bit when handling an ATS translation with
> write permission request, even when PTE RW bit is clear. This may occur by
> direct translation (which would cause a PPR) or by prefetch request from
> the ATC.
>
> This is observed in practice when the IOMMU L2 modifies a PTE which maps a
> pagecache page. The ext4 filesystem driver BUGs when asked to writeback
> these (non-modified) pages.
>
> Enable ATS write permission check in the Kaveri IOMMU L2 if BIOS has not.
>
> Signed-off-by: Jay Cornwall <jay-gJmSnxjMpeIFV7jr3Ov9Ew@public.gmane.org>
> Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> # v3.19+
> ---
> drivers/iommu/amd_iommu_init.c | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
Applied, thanks.
prev parent reply other threads:[~2016-02-25 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 21:48 [PATCH] iommu/amd: Apply workaround for ATS write permission check Jay Cornwall
[not found] ` <1455140881-17041-1-git-send-email-jay-gJmSnxjMpeIFV7jr3Ov9Ew@public.gmane.org>
2016-02-25 15:07 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225150727.GD2280@suse.de \
--to=jroedel-l3a5bk7wagm@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jay-gJmSnxjMpeIFV7jr3Ov9Ew@public.gmane.org \
--cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).