iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] iommu/dma: Fix NEED_SG_DMA_LENGTH dependency
@ 2016-02-29 11:13 Robin Murphy
       [not found] ` <189f8d7a6b1598108dc8e9f1777c67b07a4bd781.1456744313.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Robin Murphy @ 2016-02-29 11:13 UTC (permalink / raw)
  To: joro-zLv9SwRftAIdnm+yROfE0A, arnd-r2nGTMty4D4
  Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

IOMMU_DMA does indeed depend on scatterlists having a DMA length, but
the NEED_SG_DMA_LENGTH symbol should be selected, not depended upon.

Reported-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Signed-off-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
---
 drivers/iommu/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
index b325954..83f1a65 100644
--- a/drivers/iommu/Kconfig
+++ b/drivers/iommu/Kconfig
@@ -70,9 +70,9 @@ config OF_IOMMU
 # IOMMU-agnostic DMA-mapping layer
 config IOMMU_DMA
 	bool
-	depends on NEED_SG_DMA_LENGTH
 	select IOMMU_API
 	select IOMMU_IOVA
+	select NEED_SG_DMA_LENGTH
 
 config FSL_PAMU
 	bool "Freescale IOMMU support"
-- 
2.7.2.333.g70bd996.dirty

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] iommu/dma: Fix NEED_SG_DMA_LENGTH dependency
       [not found] ` <189f8d7a6b1598108dc8e9f1777c67b07a4bd781.1456744313.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
@ 2016-02-29 11:30   ` Arnd Bergmann
  2016-02-29 16:28   ` Joerg Roedel
  1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2016-02-29 11:30 UTC (permalink / raw)
  To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
  Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA

On Monday 29 February 2016 11:13:39 Robin Murphy wrote:
> IOMMU_DMA does indeed depend on scatterlists having a DMA length, but
> the NEED_SG_DMA_LENGTH symbol should be selected, not depended upon.
> 
> Reported-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
> Signed-off-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
> 

Acked-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iommu/dma: Fix NEED_SG_DMA_LENGTH dependency
       [not found] ` <189f8d7a6b1598108dc8e9f1777c67b07a4bd781.1456744313.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
  2016-02-29 11:30   ` Arnd Bergmann
@ 2016-02-29 16:28   ` Joerg Roedel
  1 sibling, 0 replies; 3+ messages in thread
From: Joerg Roedel @ 2016-02-29 16:28 UTC (permalink / raw)
  To: Robin Murphy
  Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	arnd-r2nGTMty4D4

On Mon, Feb 29, 2016 at 11:13:39AM +0000, Robin Murphy wrote:
> IOMMU_DMA does indeed depend on scatterlists having a DMA length, but
> the NEED_SG_DMA_LENGTH symbol should be selected, not depended upon.
> 
> Reported-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
> Signed-off-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
> ---
>  drivers/iommu/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-02-29 16:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-29 11:13 [PATCH] iommu/dma: Fix NEED_SG_DMA_LENGTH dependency Robin Murphy
     [not found] ` <189f8d7a6b1598108dc8e9f1777c67b07a4bd781.1456744313.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2016-02-29 11:30   ` Arnd Bergmann
2016-02-29 16:28   ` Joerg Roedel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).