* [patch 1/2] iommu/mediatek: signedness bug in probe function
@ 2016-03-02 10:10 Dan Carpenter
2016-03-02 13:53 ` Joerg Roedel
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-03-02 10:10 UTC (permalink / raw)
To: Joerg Roedel, Yong Wu
Cc: Matthias Brugger, kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
"larb_nr" needs to be signed for the error handling to work. "i" can
be int as well.
Fixes: 0df4fabe208d ('iommu/mediatek: Add mt8173 IOMMU driver')
Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
index 721ffdb..1a4022c 100644
--- a/drivers/iommu/mtk_iommu.c
+++ b/drivers/iommu/mtk_iommu.c
@@ -578,7 +578,7 @@ static int mtk_iommu_probe(struct platform_device *pdev)
struct resource *res;
struct component_match *match = NULL;
void *protect;
- unsigned int i, larb_nr;
+ int i, larb_nr;
int ret;
data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch 1/2] iommu/mediatek: signedness bug in probe function
2016-03-02 10:10 [patch 1/2] iommu/mediatek: signedness bug in probe function Dan Carpenter
@ 2016-03-02 13:53 ` Joerg Roedel
0 siblings, 0 replies; 2+ messages in thread
From: Joerg Roedel @ 2016-03-02 13:53 UTC (permalink / raw)
To: Dan Carpenter
Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Matthias Brugger
On Wed, Mar 02, 2016 at 01:10:06PM +0300, Dan Carpenter wrote:
> "larb_nr" needs to be signed for the error handling to work. "i" can
> be int as well.
>
> Fixes: 0df4fabe208d ('iommu/mediatek: Add mt8173 IOMMU driver')
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
> index 721ffdb..1a4022c 100644
> --- a/drivers/iommu/mtk_iommu.c
> +++ b/drivers/iommu/mtk_iommu.c
> @@ -578,7 +578,7 @@ static int mtk_iommu_probe(struct platform_device *pdev)
> struct resource *res;
> struct component_match *match = NULL;
> void *protect;
> - unsigned int i, larb_nr;
> + int i, larb_nr;
> int ret;
>
> data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
I merged a similar fix from Andrzej Hajda yesterday.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-02 13:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-02 10:10 [patch 1/2] iommu/mediatek: signedness bug in probe function Dan Carpenter
2016-03-02 13:53 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).