* [patch] iommu/amd: Signedness bug in acpihid_device_group()
@ 2016-04-11 7:14 Dan Carpenter
2016-04-11 7:22 ` Wan, Vincent
2016-04-11 14:11 ` Joerg Roedel
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2016-04-11 7:14 UTC (permalink / raw)
To: Joerg Roedel, Wan Zongshun
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
"devid" needs to be signed for the error handling to work.
Fixes:b097d11a0fa3f ('iommu/amd: Manage iommu_group for ACPI HID devices')
Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index c430c10..12f7779 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -283,7 +283,7 @@ static struct iommu_dev_data *get_dev_data(struct device *dev)
static struct iommu_group *acpihid_device_group(struct device *dev)
{
struct acpihid_map_entry *p, *entry = NULL;
- u16 devid;
+ int devid;
devid = get_acpihid_device_id(dev, &entry);
if (devid < 0)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [patch] iommu/amd: Signedness bug in acpihid_device_group()
2016-04-11 7:14 [patch] iommu/amd: Signedness bug in acpihid_device_group() Dan Carpenter
@ 2016-04-11 7:22 ` Wan, Vincent
2016-04-11 14:11 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Wan, Vincent @ 2016-04-11 7:22 UTC (permalink / raw)
To: Dan Carpenter, Joerg Roedel
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> From: Dan Carpenter [mailto:dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org]
> Sent: Monday, April 11, 2016 3:15 PM
> To: Joerg Roedel; Wan, Vincent
> Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; kernel-
> janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Subject: [patch] iommu/amd: Signedness bug in acpihid_device_group()
>
> "devid" needs to be signed for the error handling to work.
>
> Fixes:b097d11a0fa3f ('iommu/amd: Manage iommu_group for ACPI HID
> devices')
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> index c430c10..12f7779 100644
> --- a/drivers/iommu/amd_iommu.c
> +++ b/drivers/iommu/amd_iommu.c
> @@ -283,7 +283,7 @@ static struct iommu_dev_data *get_dev_data(struct
> device *dev) static struct iommu_group *acpihid_device_group(struct device
> *dev) {
> struct acpihid_map_entry *p, *entry = NULL;
> - u16 devid;
> + int devid;
Sure, thanks for your patch.
Wan Zongshun.
>
> devid = get_acpihid_device_id(dev, &entry);
> if (devid < 0)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] iommu/amd: Signedness bug in acpihid_device_group()
2016-04-11 7:14 [patch] iommu/amd: Signedness bug in acpihid_device_group() Dan Carpenter
2016-04-11 7:22 ` Wan, Vincent
@ 2016-04-11 14:11 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Joerg Roedel @ 2016-04-11 14:11 UTC (permalink / raw)
To: Dan Carpenter
Cc: Wan Zongshun, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Mon, Apr 11, 2016 at 10:14:46AM +0300, Dan Carpenter wrote:
> "devid" needs to be signed for the error handling to work.
>
> Fixes:b097d11a0fa3f ('iommu/amd: Manage iommu_group for ACPI HID devices')
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-11 14:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-11 7:14 [patch] iommu/amd: Signedness bug in acpihid_device_group() Dan Carpenter
2016-04-11 7:22 ` Wan, Vincent
2016-04-11 14:11 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).