From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Keeping Subject: Re: [PATCH] iommu/rockchip: fix zap cache during device attach Date: Sun, 15 May 2016 12:16:39 +0100 Message-ID: <20160515111638.GA9715@river> References: <20160510155046.24515-1-john@metanate.com> <11003810.ccjcAXkzhi@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <11003810.ccjcAXkzhi@phil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Heiko Stuebner Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, ZhengShunQian , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Sat, May 14, 2016 at 10:19:43PM +0200, Heiko Stuebner wrote: > Am Dienstag, 10. Mai 2016, 16:50:46 schrieb John Keeping: > > rk_iommu_command() takes a struct rk_iommu and iterates over the slave > > MMUs, so this is doubly wrong in that we're passing in the wrong pointer > > and talking to MMUs that we shouldn't be. > > > > Fixes: cd6438c5f844 ("iommu/rockchip: Reconstruct to support multi > > slaves") Signed-off-by: John Keeping > > on a rk3288-veyron > Tested-by: Heiko Stuebner > Reviewed-by: Heiko Stuebner > > I was wondering for a short time why this didn't spew warnings until I > realized that the iommu->bases[i] is of course a void* . Yes, although sparse catches it because iommu->bases[i] is __iomem so it shows up as a namespace warning.